Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2294383002: Make OffscreenCanvas a member of CanvasImageSource (Closed)

Created:
4 years, 3 months ago by Justin Novosad
Modified:
4 years, 3 months ago
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make OffscreenCanvas a member of CanvasImageSource This change makes it possible to call the drawImage and createPattern methods of CanvasRenderingContext2D with an OffscreenCAnvas as an argument BUG=632015 TBR=haraken@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/605fa62ea2c9ac2924ff08f21106775d412bed5b Cr-Commit-Position: refs/heads/master@{#415942}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -76 lines) Patch
M third_party/WebKit/LayoutTests/canvas/philip/tests/2d.pattern.image.string-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/canvas/philip/tests/2d.pattern.image.undefined-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-drawImage.html View 2 chunks +18 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-drawImage-expected.html View 2 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-2d-pattern-in-worker.html View 2 chunks +22 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-transferable-exceptions.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-transferable-exceptions-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-pattern-behaviour-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/drawImage-with-broken-image-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/generated.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 2 chunks +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasImageSource.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h View 1 3 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h View 3 chunks +11 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp View 1 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h View 1 3 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp View 1 2 chunks +12 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
Justin Novosad
@kbr needed for Source/modules/webgl and Source/core OWNERS @xlai: PTAL https://codereview.chromium.org/2294383002/diff/1/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (left): https://codereview.chromium.org/2294383002/diff/1/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp#oldcode1120 third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:1120: ...
4 years, 3 months ago (2016-08-31 18:54:23 UTC) #7
Ken Russell (switch to Gerrit)
Nice work and tests. LGTM
4 years, 3 months ago (2016-08-31 22:32:14 UTC) #12
Justin Novosad
haraken@: Owner TBR for trivial change to third_party/WebKit/Source/bindings/modules/v8/generated.gni (name change for auto-gen union typedef)
4 years, 3 months ago (2016-09-01 13:34:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294383002/20001
4 years, 3 months ago (2016-09-01 13:35:06 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 13:42:39 UTC) #18
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/605fa62ea2c9ac2924ff08f21106775d412bed5b Cr-Commit-Position: refs/heads/master@{#415942}
4 years, 3 months ago (2016-09-01 13:44:38 UTC) #20
haraken
4 years, 3 months ago (2016-09-01 14:21:21 UTC) #21
Message was sent while issue was closed.
On 2016/09/01 13:44:38, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/605fa62ea2c9ac2924ff08f21106775d412bed5b
> Cr-Commit-Position: refs/heads/master@{#415942}

bindings/ LGTM

Powered by Google App Engine
This is Rietveld 408576698