Deflake paint/invalidation/animated-gif*.html

Deflake paint/invalidation/animated-gif*.html

- Replace timeouts with advanceImageAnimation()
- Don't start tracking paint invalidations before repaintTest to avoid
  extra paint invalidations sometimes. advanceImageAnimation() can
  ensure a new animation frame so we don't need to start tracking
  earlier which was required when we used the timeout.

BUG=619103
Committed: https://crrev.com/a91010926d8c5c77e395f2dab49b4e64f11e6c00
Cr-Commit-Position: refs/heads/master@{#417641}

[Xianzhu, 2016-09-07 20:08:42]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 20:09:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 21:30:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 21:30:06]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2016-09-07 21:58:52]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2016-09-07 22:01:28]

https://codereview.chromium.org/2319833002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2319833002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/TestExpectations:77: crbug.com/619103
paint/invalidation/animated-gif-background-offscreen.html [ Pass Failure ]
The above two "under-invalidation" failures look weird. There seem some pixels
along the diagonal on the canvas changed. Investigating this and would like to
create another patch to fix it.

[chrishtr, 2016-09-07 22:16:53]

On 2016/09/07 at 22:01:28, wangxianzhu wrote:
>
https://codereview.chromium.org/2319833002/diff/1/third_party/WebKit/LayoutTe...
> File third_party/WebKit/LayoutTests/TestExpectations (right):
> 
>
https://codereview.chromium.org/2319833002/diff/1/third_party/WebKit/LayoutTe...
> third_party/WebKit/LayoutTests/TestExpectations:77: crbug.com/619103
paint/invalidation/animated-gif-background-offscreen.html [ Pass Failure ]
> The above two "under-invalidation" failures look weird. There seem some pixels
along the diagonal on the canvas changed. Investigating this and would like to
create another patch to fix it.

But still review this one?

[Xianzhu, 2016-09-07 22:18:36]

On 2016/09/07 22:16:53, chrishtr wrote:
> On 2016/09/07 at 22:01:28, wangxianzhu wrote:
> >
>
https://codereview.chromium.org/2319833002/diff/1/third_party/WebKit/LayoutTe...
> > File third_party/WebKit/LayoutTests/TestExpectations (right):
> > 
> >
>
https://codereview.chromium.org/2319833002/diff/1/third_party/WebKit/LayoutTe...
> > third_party/WebKit/LayoutTests/TestExpectations:77: crbug.com/619103
> paint/invalidation/animated-gif-background-offscreen.html [ Pass Failure ]
> > The above two "under-invalidation" failures look weird. There seem some
pixels
> along the diagonal on the canvas changed. Investigating this and would like to
> create another patch to fix it.
> 
> But still review this one?

Yes. Fixing the weird (preexisting) under-invalidations will be a separate CL.

[Xianzhu, 2016-09-07 22:33:43]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 22:34:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-09-07 22:35:24]

On 2016/09/07 22:18:36, Xianzhu wrote:
> On 2016/09/07 22:16:53, chrishtr wrote:
> 
> Yes. Fixing the weird (preexisting) under-invalidations will be a separate CL.

I found the reason of the "weird under-invalidation" and fixed it in the latest
patch.

- We should disable under-invalidation checking for offscreen gif animations
because we intentionally not to invalidate;
- Previously the under-invalidation was reported on diagonal line was because a
bug when generating the report.

[commit-bot: I haz the power, 2016-09-08 00:47:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 00:47:27]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2016-09-09 16:38:05]

lgtm

[Xianzhu, 2016-09-09 16:41:19]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-09-09 16:41:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 18:27:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-09 18:29:07]

Description was changed from

==========
Deflake paint/invalidation/animated-gif*.html

- Replace timeouts with advanceImageAnimation()
- Don't start tracking paint invalidations before repaintTest to avoid
  extra paint invalidations sometimes. advanceImageAnimation() can
  ensure a new animation frame so we don't need to start tracking
  earlier which was required when we used the timeout.

BUG=619103
==========

to

==========
Deflake paint/invalidation/animated-gif*.html

- Replace timeouts with advanceImageAnimation()
- Don't start tracking paint invalidations before repaintTest to avoid
  extra paint invalidations sometimes. advanceImageAnimation() can
  ensure a new animation frame so we don't need to start tracking
  earlier which was required when we used the timeout.

BUG=619103

Committed: https://crrev.com/a91010926d8c5c77e395f2dab49b4e64f11e6c00
Cr-Commit-Position: refs/heads/master@{#417641}
==========

[commit-bot: I haz the power, 2016-09-09 18:29:08]

Patchset 2 (id:??) landed as
https://crrev.com/a91010926d8c5c77e395f2dab49b4e64f11e6c00
Cr-Commit-Position: refs/heads/master@{#417641}