third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background.html - Issue 2319833002: Deflake paint/invalidation/animated-gif*.html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background.html

Issue 2319833002: Deflake paint/invalidation/animated-gif*.html (Closed)

Patch Set: Disable under-invalidation checking for offscreen gif animation Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/animated-gif.html ('k') | third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background-offscreen.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background.html

diff --git a/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background.html b/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background.html

index fe5509c482cc73176517a1a0bc9fc82ecca993d2..4dccaedee2f1ae8723e38fb5d18a006d894b6150 100644

--- a/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background.html

+++ b/third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-background.html

@@ -1,31 +1,27 @@

<!doctype HTML>

<body>

-<div id="targetImage" style="width: 50px; height: 50px">

+ <div id="targetImage" style="width: 50px; height: 50px"></div>

+ <img id="testTarget" style="visibility: hidden">

</div>

-<img id="testTarget" style="visibility: hidden">

window.testIsAsync = true;

function repaintTest() {

- window.internals.advanceImageAnimation(testTarget);

+ if (window.internals)

+ internals.advanceImageAnimation(testTarget);

requestAnimationFrame(function() {

finishRepaintTest();

});

}

-function targetImageOnload() {

- window.internals.startTrackingRepaints(document);

- runRepaintTest();

onload = function() {

targetImage.style.background = "url(../../fast/backgrounds/resources/red-green-animated.gif)";

// Use a parallel image element has a hack to detect whether the image has loaded, and therefore

// we'll get a frame.

- testTarget.onload = targetImageOnload;

+ testTarget.onload = runRepaintTest;

testTarget.src = "../../fast/backgrounds/resources/red-green-animated.gif";

}

</script>