Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

Issue 2319833002: Deflake paint/invalidation/animated-gif*.html (Closed)
Patch Set: Disable under-invalidation checking for offscreen gif animation Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-transformed-offscreen.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 761 matching lines...) Expand 10 before | Expand all | Expand 10 after
772 } 772 }
773 json->setArray("paintInvalidations", std::move(paintInvalidation sJSON)); 773 json->setArray("paintInvalidations", std::move(paintInvalidation sJSON));
774 } 774 }
775 775
776 Vector<UnderPaintInvalidation>& underPaintInvalidations = it->value. underPaintInvalidations; 776 Vector<UnderPaintInvalidation>& underPaintInvalidations = it->value. underPaintInvalidations;
777 if (!underPaintInvalidations.isEmpty()) { 777 if (!underPaintInvalidations.isEmpty()) {
778 std::unique_ptr<JSONArray> underPaintInvalidationsJSON = JSONArr ay::create(); 778 std::unique_ptr<JSONArray> underPaintInvalidationsJSON = JSONArr ay::create();
779 for (auto& underPaintInvalidation : underPaintInvalidations) { 779 for (auto& underPaintInvalidation : underPaintInvalidations) {
780 std::unique_ptr<JSONObject> underPaintInvalidationJSON = JSO NObject::create(); 780 std::unique_ptr<JSONObject> underPaintInvalidationJSON = JSO NObject::create();
781 underPaintInvalidationJSON->setDouble("x", underPaintInvalid ation.x); 781 underPaintInvalidationJSON->setDouble("x", underPaintInvalid ation.x);
782 underPaintInvalidationJSON->setDouble("y", underPaintInvalid ation.x); 782 underPaintInvalidationJSON->setDouble("y", underPaintInvalid ation.y);
783 underPaintInvalidationJSON->setString("oldPixel", Color(unde rPaintInvalidation.oldPixel).nameForLayoutTreeAsText()); 783 underPaintInvalidationJSON->setString("oldPixel", Color(unde rPaintInvalidation.oldPixel).nameForLayoutTreeAsText());
784 underPaintInvalidationJSON->setString("newPixel", Color(unde rPaintInvalidation.newPixel).nameForLayoutTreeAsText()); 784 underPaintInvalidationJSON->setString("newPixel", Color(unde rPaintInvalidation.newPixel).nameForLayoutTreeAsText());
785 underPaintInvalidationsJSON->pushObject(std::move(underPaint InvalidationJSON)); 785 underPaintInvalidationsJSON->pushObject(std::move(underPaint InvalidationJSON));
786 } 786 }
787 json->setArray("underPaintInvalidations", std::move(underPaintIn validationsJSON)); 787 json->setArray("underPaintInvalidations", std::move(underPaintIn validationsJSON));
788 } 788 }
789 } 789 }
790 } 790 }
791 791
792 if ((flags & LayerTreeIncludesPaintingPhases) && m_paintingPhase) { 792 if ((flags & LayerTreeIncludesPaintingPhases) && m_paintingPhase) {
(...skipping 553 matching lines...) Expand 10 before | Expand all | Expand 10 after
1346 { 1346 {
1347 if (!layer) { 1347 if (!layer) {
1348 fprintf(stderr, "Cannot showGraphicsLayerTree for (nil).\n"); 1348 fprintf(stderr, "Cannot showGraphicsLayerTree for (nil).\n");
1349 return; 1349 return;
1350 } 1350 }
1351 1351
1352 String output = layer->layerTreeAsText(blink::LayerTreeIncludesDebugInfo); 1352 String output = layer->layerTreeAsText(blink::LayerTreeIncludesDebugInfo);
1353 fprintf(stderr, "%s\n", output.utf8().data()); 1353 fprintf(stderr, "%s\n", output.utf8().data());
1354 } 1354 }
1355 #endif 1355 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/animated-gif-transformed-offscreen.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698