Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 2318833003: Remove activity_log's Util::DropObsoleteTables(). (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
Reviewers:
felt, mvrable
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, felt, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove activity_log's Util::DropObsoleteTables(). After three years, the obsolete tables are probably gone for good. Committed: https://crrev.com/47a8860f5d7cd3fc9862b7bec4b6a8883b47d305 Cr-Commit-Position: refs/heads/master@{#417349}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -38 lines) Patch
M chrome/browser/extensions/activity_log/activity_log_policy.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_policy.cc View 3 chunks +0 lines, -24 lines 1 comment Download
M chrome/browser/extensions/activity_log/counting_policy.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/activity_log/fullstream_ui_policy.cc View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Lei Zhang
Safe to delete the deleter? https://codereview.chromium.org/2318833003/diff/1/chrome/browser/extensions/activity_log/activity_log_policy.cc File chrome/browser/extensions/activity_log/activity_log_policy.cc (left): https://codereview.chromium.org/2318833003/diff/1/chrome/browser/extensions/activity_log/activity_log_policy.cc#oldcode29 chrome/browser/extensions/activity_log/activity_log_policy.cc:29: // found. This probably ...
4 years, 3 months ago (2016-09-07 08:17:45 UTC) #7
mvrable
lgtm I haven't been actively working on Chromium in a while, but these old database ...
4 years, 3 months ago (2016-09-07 20:25:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318833003/1
4 years, 3 months ago (2016-09-08 17:22:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 18:33:48 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 18:36:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47a8860f5d7cd3fc9862b7bec4b6a8883b47d305
Cr-Commit-Position: refs/heads/master@{#417349}

Powered by Google App Engine
This is Rietveld 408576698