Remove activity_log's Util::DropObsoleteTables().

chrome/browser/extensions/activity_log/activity_log_policy.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/activity_log/activity_log_policy.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/files/file_path.h"
 #include "base/json/json_string_value_serializer.h"
 #include "base/logging.h"
 #include "base/macros.h"
-#include "base/strings/stringprintf.h"
 #include "base/time/clock.h"
 #include "base/time/time.h"
 #include "chrome/browser/extensions/activity_log/activity_action_constants.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/browser/browser_thread.h"
 #include "extensions/common/extension.h"
 #include "url/gurl.h"
 
 using content::BrowserThread;
 
 namespace constants = activity_log_constants;
 
-namespace {
-// Obsolete database tables: these should be dropped from the database if
-// found.

[Lei Zhang, 2016/09/07 08:17:44]

This probably should have had a TODO attached to remove after a year or two.

-const char* const kObsoleteTables[] = {"activitylog_apis",
-                                       "activitylog_blocked",
-                                       "activitylog_urls"};
-}  // namespace
-
 namespace extensions {
 
 ActivityLogPolicy::ActivityLogPolicy(Profile* profile) {}
 
 ActivityLogPolicy::~ActivityLogPolicy() {}
 
 void ActivityLogPolicy::SetClockForTesting(std::unique_ptr<base::Clock> clock) {
   testing_clock_.reset(clock.release());
 }
 
@@ skipping 112 matching lines @@
       *early_bound = morning_midnight.ToInternalValue();
       *late_bound = base::Time::Max().ToInternalValue();
   } else {
       base::Time early_time = Util::AddDays(morning_midnight, -days_ago);
       base::Time late_time = Util::AddDays(early_time, 1);
       *early_bound = early_time.ToInternalValue();
       *late_bound = late_time.ToInternalValue();
   }
 }
 
-// static
-bool ActivityLogPolicy::Util::DropObsoleteTables(sql::Connection* db) {
-  for (size_t i = 0; i < arraysize(kObsoleteTables); i++) {
-    const char* table_name = kObsoleteTables[i];
-    if (db->DoesTableExist(table_name)) {
-      std::string drop_statement =
-          base::StringPrintf("DROP TABLE %s", table_name);
-      if (!db->Execute(drop_statement.c_str())) {
-        return false;
-      }
-    }
-  }
-  return true;
-}
-
 }  // namespace extensions