Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2266)

Unified Diff: chrome/browser/extensions/activity_log/activity_log_policy.cc

Issue 2318833003: Remove activity_log's Util::DropObsoleteTables(). (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/activity_log_policy.cc
diff --git a/chrome/browser/extensions/activity_log/activity_log_policy.cc b/chrome/browser/extensions/activity_log/activity_log_policy.cc
index 0d39f9cfb03d8deceea163c190898b7aa2af27f1..3ef4684f02d7ed827b55006318949c3bdce29e57 100644
--- a/chrome/browser/extensions/activity_log/activity_log_policy.cc
+++ b/chrome/browser/extensions/activity_log/activity_log_policy.cc
@@ -11,7 +11,6 @@
#include "base/json/json_string_value_serializer.h"
#include "base/logging.h"
#include "base/macros.h"
-#include "base/strings/stringprintf.h"
#include "base/time/clock.h"
#include "base/time/time.h"
#include "chrome/browser/extensions/activity_log/activity_action_constants.h"
@@ -24,14 +23,6 @@ using content::BrowserThread;
namespace constants = activity_log_constants;
-namespace {
-// Obsolete database tables: these should be dropped from the database if
-// found.
Lei Zhang 2016/09/07 08:17:44 This probably should have had a TODO attached to r
-const char* const kObsoleteTables[] = {"activitylog_apis",
- "activitylog_blocked",
- "activitylog_urls"};
-} // namespace
-
namespace extensions {
ActivityLogPolicy::ActivityLogPolicy(Profile* profile) {}
@@ -164,19 +155,4 @@ void ActivityLogPolicy::Util::ComputeDatabaseTimeBounds(const base::Time& now,
}
}
-// static
-bool ActivityLogPolicy::Util::DropObsoleteTables(sql::Connection* db) {
- for (size_t i = 0; i < arraysize(kObsoleteTables); i++) {
- const char* table_name = kObsoleteTables[i];
- if (db->DoesTableExist(table_name)) {
- std::string drop_statement =
- base::StringPrintf("DROP TABLE %s", table_name);
- if (!db->Execute(drop_statement.c_str())) {
- return false;
- }
- }
- }
- return true;
-}
-
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698