Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4568)

Unified Diff: chrome/browser/extensions/activity_log/fullstream_ui_policy.cc

Issue 2318833003: Remove activity_log's Util::DropObsoleteTables(). (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/fullstream_ui_policy.cc
diff --git a/chrome/browser/extensions/activity_log/fullstream_ui_policy.cc b/chrome/browser/extensions/activity_log/fullstream_ui_policy.cc
index c65fdb7adabe1ab24a17710df06f72c72309d512..78eece6f22579d6c96c11f384f0f2b6732779366 100644
--- a/chrome/browser/extensions/activity_log/fullstream_ui_policy.cc
+++ b/chrome/browser/extensions/activity_log/fullstream_ui_policy.cc
@@ -57,9 +57,6 @@ FullStreamUIPolicy::FullStreamUIPolicy(Profile* profile)
FullStreamUIPolicy::~FullStreamUIPolicy() {}
bool FullStreamUIPolicy::InitDatabase(sql::Connection* db) {
- if (!Util::DropObsoleteTables(db))
- return false;
-
// Create the unified activity log entry table.
return ActivityDatabase::InitializeTable(db,
kTableName,
@@ -83,8 +80,7 @@ bool FullStreamUIPolicy::FlushDatabase(sql::Connection* db) {
sql::Statement statement(db->GetCachedStatement(
sql::StatementID(SQL_FROM_HERE), sql_str.c_str()));
- Action::ActionVector::size_type i;
- for (i = 0; i != queued_actions_.size(); ++i) {
+ for (size_t i = 0; i != queued_actions_.size(); ++i) {
const Action& action = *queued_actions_[i];
statement.Reset(true);
statement.BindString(0, action.extension_id());

Powered by Google App Engine
This is Rietveld 408576698