Submit CompositorFrame from worker

Submit CompositorFrame from worker

This CL enables sending compositor frame from OffscreenCanvas on worker
to browser. It also makes commit() throws InvalidStateError when user
call the function without calling transferControlToOffscreen. Two layout
tests are added.

TBR=tsepez@chromium.org
BUG=563858
Committed: https://crrev.com/872147e3a729517162d4b155164ec1c75d942bd7
Cr-Commit-Position: refs/heads/master@{#417407}

[xlai (Olivia), 2016-09-07 20:47:12]

Description was changed from

==========
Submit CompositorFrame from worker

BUG=563858
==========

to

==========
Submit CompositorFrame from worker

This CL enables sending compositor frame from OffscreenCanvas on worker
to browser. It also makes commit() throws InvalidStateError when user
call the function without calling transferControlToOffscreen. Two layout
tests are accompanied.

BUG=563858
==========

[xlai (Olivia), 2016-09-07 20:47:12]

xlai@chromium.org changed reviewers:
+ junov@chromium.org

[xlai (Olivia), 2016-09-07 20:47:55]

Description was changed from

==========
Submit CompositorFrame from worker

This CL enables sending compositor frame from OffscreenCanvas on worker
to browser. It also makes commit() throws InvalidStateError when user
call the function without calling transferControlToOffscreen. Two layout
tests are accompanied.

BUG=563858
==========

to

==========
Submit CompositorFrame from worker

This CL enables sending compositor frame from OffscreenCanvas on worker
to browser. It also makes commit() throws InvalidStateError when user
call the function without calling transferControlToOffscreen. Two layout
tests are added.

BUG=563858
==========

[jbroman, 2016-09-07 20:52:58]

FYI the static_cast change is out for review at:
https://codereview.chromium.org/2321713002

[xlai (Olivia), 2016-09-07 20:55:17]

On 2016/09/07 20:52:58, jbroman wrote:
> FYI the static_cast change is out for review at:
> https://codereview.chromium.org/2321713002

Yup I know. I'm gonna rebase the change in ScriptValueSerializer.h after
the static_cast change is landed.

[Justin Novosad, 2016-09-07 21:40:15]

https://codereview.chromium.org/2318383002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-worker.html
(right):

https://codereview.chromium.org/2318383002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-worker.html:28:
assert_equals(actualDataURL, expectedDataURL,
I don't understand how this verifies anything about the success to the call to
commit.  Come to think of it, calling toDataURL on a canvas that has transferred
control should probably throw an exception.

https://codereview.chromium.org/2318383002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp (right):

https://codereview.chromium.org/2318383002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp:149: //
(either main or worker) to browser process and remains unchanged
*the* browser process

https://codereview.chromium.org/2318383002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
(right):

https://codereview.chromium.org/2318383002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp:53:
exceptionState.throwDOMException(InvalidStateError, "Commit() has no effect if
HTMLCanvasElement.transferControlToOffscreen() is not called.");
This message is not true: there is an effect, an exception is thrown.  I think
the message would be clearer like this: "commit() was called on a context whose
OffscreenCanvas is not associated with an canvas element."

[xlai (Olivia), 2016-09-08 15:27:15]

https://codereview.chromium.org/2318383002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-worker.html
(right):

https://codereview.chromium.org/2318383002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-worker.html:28:
assert_equals(actualDataURL, expectedDataURL,
Changing this test by using ref test again. I'll consolidate those 
transferred control canvas's functions that should throw exception
and upload another patch.

On 2016/09/07 21:40:15, Justin Novosad wrote:
> I don't understand how this verifies anything about the success to the call to
> commit.  Come to think of it, calling toDataURL on a canvas that has
transferred
> control should probably throw an exception.

https://codereview.chromium.org/2318383002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp (right):

https://codereview.chromium.org/2318383002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp:149: //
(either main or worker) to browser process and remains unchanged
On 2016/09/07 21:40:15, Justin Novosad wrote:
> *the* browser process

Done.

https://codereview.chromium.org/2318383002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp
(right):

https://codereview.chromium.org/2318383002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp:53:
exceptionState.throwDOMException(InvalidStateError, "Commit() has no effect if
HTMLCanvasElement.transferControlToOffscreen() is not called.");
On 2016/09/07 21:40:15, Justin Novosad wrote:
> This message is not true: there is an effect, an exception is thrown.  I think
> the message would be clearer like this: "commit() was called on a context
whose
> OffscreenCanvas is not associated with an canvas element."

Done.

[xlai (Olivia), 2016-09-08 18:51:38]

Just added a comment saying that I'm working on crbug.com/645173.

[Justin Novosad, 2016-09-08 19:32:32]

lgtm

[xlai (Olivia), 2016-09-08 19:56:48]

Description was changed from

==========
Submit CompositorFrame from worker

This CL enables sending compositor frame from OffscreenCanvas on worker
to browser. It also makes commit() throws InvalidStateError when user
call the function without calling transferControlToOffscreen. Two layout
tests are added.

BUG=563858
==========

to

==========
Submit CompositorFrame from worker

This CL enables sending compositor frame from OffscreenCanvas on worker
to browser. It also makes commit() throws InvalidStateError when user
call the function without calling transferControlToOffscreen. Two layout
tests are added.


TBR=tsepez@chromium.org
BUG=563858
==========

[xlai (Olivia), 2016-09-08 19:57:12]

xlai@chromium.org changed reviewers:
+ tsepez@chromium.org

[xlai (Olivia), 2016-09-08 19:58:27]

The CQ bit was checked by xlai@chromium.org

[commit-bot: I haz the power, 2016-09-08 19:59:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-08 20:16:23]

RS LGTM on removing comment from mojom.

[commit-bot: I haz the power, 2016-09-08 21:39:10]

Description was changed from

==========
Submit CompositorFrame from worker

This CL enables sending compositor frame from OffscreenCanvas on worker
to browser. It also makes commit() throws InvalidStateError when user
call the function without calling transferControlToOffscreen. Two layout
tests are added.


TBR=tsepez@chromium.org
BUG=563858
==========

to

==========
Submit CompositorFrame from worker

This CL enables sending compositor frame from OffscreenCanvas on worker
to browser. It also makes commit() throws InvalidStateError when user
call the function without calling transferControlToOffscreen. Two layout
tests are added.


TBR=tsepez@chromium.org
BUG=563858
==========

[commit-bot: I haz the power, 2016-09-08 21:39:12]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-08 21:43:18]

Description was changed from

==========
Submit CompositorFrame from worker

This CL enables sending compositor frame from OffscreenCanvas on worker
to browser. It also makes commit() throws InvalidStateError when user
call the function without calling transferControlToOffscreen. Two layout
tests are added.


TBR=tsepez@chromium.org
BUG=563858
==========

to

==========
Submit CompositorFrame from worker

This CL enables sending compositor frame from OffscreenCanvas on worker
to browser. It also makes commit() throws InvalidStateError when user
call the function without calling transferControlToOffscreen. Two layout
tests are added.

TBR=tsepez@chromium.org
BUG=563858

Committed: https://crrev.com/872147e3a729517162d4b155164ec1c75d942bd7
Cr-Commit-Position: refs/heads/master@{#417407}
==========

[commit-bot: I haz the power, 2016-09-08 21:43:20]

Patchset 5 (id:??) landed as
https://crrev.com/872147e3a729517162d4b155164ec1c75d942bd7
Cr-Commit-Position: refs/heads/master@{#417407}