Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2321713002: Add a static_cast to fix a bug in ScriptValueSerializer::doReadUint64. (Closed)

Created:
4 years, 3 months ago by jbroman
Modified:
4 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, jbroman+watch_chromium.org, xlai (Olivia)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a static_cast to fix a bug in ScriptValueSerializer::doReadUint64. Committed: https://crrev.com/16061dc3a513554acc2cd8a65eca4becb27b2c3d Cr-Commit-Position: refs/heads/master@{#417238}

Patch Set 1 #

Patch Set 2 : FRIEND_TEST_ALL_PREFIXES #

Patch Set 3 : align the buffer, because there is an assertion that demands it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h View 1 3 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializerTest.cpp View 1 2 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
jbroman
This bug was preventing uint64_t nonces xlai@ was trying to send for OffscreenCanvas from transferring ...
4 years, 3 months ago (2016-09-07 19:37:05 UTC) #9
jbroman
Hmm, let me figure out this bit failure first.
4 years, 3 months ago (2016-09-07 22:16:56 UTC) #12
haraken
LGTM
4 years, 3 months ago (2016-09-07 23:19:36 UTC) #13
jbroman
Bot failure was just complaining about alignment. Fixed by asking the compiler to align it.
4 years, 3 months ago (2016-09-08 04:44:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321713002/40001
4 years, 3 months ago (2016-09-08 04:44:21 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-08 09:19:31 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 09:20:52 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/16061dc3a513554acc2cd8a65eca4becb27b2c3d
Cr-Commit-Position: refs/heads/master@{#417238}

Powered by Google App Engine
This is Rietveld 408576698