third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-main.html - Issue 2318383002: Submit CompositorFrame from worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-main.html

Issue 2318383002: Submit CompositorFrame from worker (Closed)

Patch Set: Adding comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-invalid-call.html ('k') | third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-worker.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-main.html

diff --git a/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-main.html b/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-main.html

index eaa07875398e6c84ea5bec5d96a528356781dcae..daa6f23bafb36fc53a0991847bdc0e9f24546312 100644

--- a/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-main.html

+++ b/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-commit-main.html

@@ -1,6 +1,11 @@

<!DOCTYPE>

+// Note: If someone see this test flaky in the future, please mark the test as

+// flaky; the code itself is not the cause of such flakiness.

+// TODO(xlai): Guarantee all OffscreenCanvas commit tests non-flaky under all cases.

+// See crbug.com/645173.

// Currently, we push a Green color frame from OffscreenCanvas; so we test

// whether the associated canvas has green pixel. In the future, when we

// change solidColorFrame to textureFrame, the expected png needs to changed too.