Remove balloon notification code. The last user was the Linux GTK port but that's deleted now.

Remove balloon notification code. The last user was the Linux GTK port but that's deleted now.

BUG=297026, 361784
R=mukai@chromium.org, stevenjb@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263150

[tfarina, 2014-04-10 16:41:06]

+Sadrul -> https://codereview.chromium.org/231213003/

[jam, 2014-04-10 16:45:14]

+erg fyi, I'll wait for you to land https://codereview.chromium.org/226413006/
first

[stevenjb, 2014-04-10 17:32:02]

+mukai@

halle-frickin-lujah, break out the champagne! Cheers John.

https://codereview.chromium.org/231723006/diff/120001/chrome/browser/extensio...
File chrome/browser/extensions/api/notifications/notifications_api.cc (right):

https://codereview.chromium.org/231723006/diff/120001/chrome/browser/extensio...
chrome/browser/extensions/api/notifications/notifications_api.cc:425:
notification->set_items(items);
It looks like the diff was just butchered and only the if
(message_center::IsRichNotificationEnabled()) statements were removed?

https://codereview.chromium.org/231723006/diff/120001/chrome/browser/notifica...
File chrome/browser/notifications/desktop_notification_service.cc (right):

https://codereview.chromium.org/231723006/diff/120001/chrome/browser/notifica...
chrome/browser/notifications/desktop_notification_service.cc:399: return
notification.notification_id();
It looks like we only call this twice, we could just embed thus code directly
and  remove the wrapper. (Not necessary though if you don't want to add to this
CL)

[stevenjb, 2014-04-10 17:32:19]

Oh, and LGTM!

[Jun Mukai, 2014-04-10 17:54:28]

lgtm!

+dewittj, petewil

[sadrul, 2014-04-10 18:20:03]

Nice! Sorry if my CL caused difficulties.

[jam, 2014-04-10 20:09:59]

thanks for the quick reviews!
sadrul: np, merging was trivial

https://codereview.chromium.org/231723006/diff/120001/chrome/browser/extensio...
File chrome/browser/extensions/api/notifications/notifications_api.cc (right):

https://codereview.chromium.org/231723006/diff/120001/chrome/browser/extensio...
chrome/browser/extensions/api/notifications/notifications_api.cc:425:
notification->set_items(items);
On 2014/04/10 17:32:03, stevenjb wrote:
> It looks like the diff was just butchered and only the if
> (message_center::IsRichNotificationEnabled()) statements were removed?

correct

I can verify that locally with a decent diff program, that's all I see

https://codereview.chromium.org/231723006/diff/120001/chrome/browser/notifica...
File chrome/browser/notifications/desktop_notification_service.cc (right):

https://codereview.chromium.org/231723006/diff/120001/chrome/browser/notifica...
chrome/browser/notifications/desktop_notification_service.cc:399: return
notification.notification_id();
On 2014/04/10 17:32:03, stevenjb wrote:
> It looks like we only call this twice, we could just embed thus code directly
> and  remove the wrapper. (Not necessary though if you don't want to add to
this
> CL)
> 

yeah i'd prefer to keep it as simple as possible :)

[Robert Sesek, 2014-04-10 20:27:09]

FYI I think there's some more resources that can be removed, too:
IDR_BALLOON_WRENCH{,_H,_P}.

[jam, 2014-04-10 20:41:51]

On 2014/04/10 20:27:09, rsesek wrote:
> FYI I think there's some more resources that can be removed, too:
> IDR_BALLOON_WRENCH{,_H,_P}.

thanks, removed