Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2728)

Unified Diff: chrome/browser/notifications/notification.cc

Issue 231723006: Remove balloon notification code. The last user was the Linux GTK port but that's deleted now. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: sync after elliot's r263101 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification.cc
===================================================================
--- chrome/browser/notifications/notification.cc (revision 263121)
+++ chrome/browser/notifications/notification.cc (working copy)
@@ -83,14 +83,6 @@
delegate_(delegate) {
// It's important to leave |icon_url_| empty with rich notifications enabled,
// to prevent "Downloading" the data url and overwriting the existing |icon|.
- if (!message_center::IsRichNotificationEnabled()) {
- // "Upconvert" the string parameters to a data: URL. Some balloon views
- // require content URL to render anything, so this serves as a backup.
- if (!icon.IsEmpty())
- icon_url_ = GURL(webui::GetBitmapDataUrl(*icon.ToSkBitmap()));
- content_url_ = GURL(
- DesktopNotificationService::CreateDataUrl(icon_url_, title, body, dir));
- }
}
Notification::Notification(const GURL& origin_url,

Powered by Google App Engine
This is Rietveld 408576698