Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: chrome/browser/notifications/desktop_notification_service.h

Issue 231723006: Remove balloon notification code. The last user was the Linux GTK port but that's deleted now. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: sync after elliot's r263101 Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/desktop_notification_service.h
===================================================================
--- chrome/browser/notifications/desktop_notification_service.h (revision 263121)
+++ chrome/browser/notifications/desktop_notification_service.h (working copy)
@@ -105,20 +105,7 @@
static base::string16 CreateDataUrl(int resource,
const std::vector<std::string>& subst);
- // Add a desktop notification. On non-Ash platforms this will generate a HTML
- // notification from the input parameters. On Ash it will generate a normal
- // ash notification. Returns the notification id.
- // TODO(mukai): remove these methods. HTML notifications are no longer
- // supported.
- static std::string AddNotification(const GURL& origin_url,
- const base::string16& title,
- const base::string16& message,
- const GURL& icon_url,
- const base::string16& replace_id,
- NotificationDelegate* delegate,
- Profile* profile);
-
- // Same as above, but takes a gfx::Image for the icon instead.
+ // Add a desktop notification.
static std::string AddIconNotification(const GURL& origin_url,
const base::string16& title,
const base::string16& message,
@@ -127,9 +114,6 @@
NotificationDelegate* delegate,
Profile* profile);
- // Remove any active notification corresponding to |notification_id|.
- static void RemoveNotification(const std::string& notification_id);
-
// The default content setting determines how to handle origins that haven't
// been allowed or denied yet. If |provider_id| is not NULL, the id of the
// provider which provided the default setting is assigned to it.

Powered by Google App Engine
This is Rietveld 408576698