Remove balloon notification code. The last user was the Linux GTK port but that's deleted now.

chrome/browser/notifications/desktop_notification_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/desktop_notification_service.h"
 
 #include "base/metrics/histogram.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread.h"
@@ skipping 366 matching lines @@
     NOTREACHED() << "unable to load template. ID: " << resource;
     return base::string16();
   }
 
   std::string data = ReplaceStringPlaceholders(template_html, subst, NULL);
   return base::UTF8ToUTF16("data:text/html;charset=utf-8," +
                                net::EscapeQueryParamValue(data, false));
 }
 
 // static
-std::string DesktopNotificationService::AddNotification(
-    const GURL& origin_url,
-    const base::string16& title,
-    const base::string16& message,
-    const GURL& icon_url,
-    const base::string16& replace_id,
-    NotificationDelegate* delegate,
-    Profile* profile) {
-  if (message_center::IsRichNotificationEnabled()) {
-    // For message center create a non-HTML notification with |icon_url|.
-    Notification notification(origin_url, icon_url, title, message,
-                              blink::WebTextDirectionDefault,
-                              base::string16(), replace_id, delegate);
-    g_browser_process->notification_ui_manager()->Add(notification, profile);
-    return notification.notification_id();
-  }
-
-  // Generate a data URL embedding the icon URL, title, and message.
-  GURL content_url(CreateDataUrl(
-      icon_url, title, message, blink::WebTextDirectionDefault));
-  Notification notification(
-      GURL(), content_url, base::string16(), replace_id, delegate);
-  g_browser_process->notification_ui_manager()->Add(notification, profile);
-  return notification.notification_id();
-}
-
-// static
 std::string DesktopNotificationService::AddIconNotification(
     const GURL& origin_url,
     const base::string16& title,
     const base::string16& message,
     const gfx::Image& icon,
     const base::string16& replace_id,
     NotificationDelegate* delegate,
     Profile* profile) {
-  if (message_center::IsRichNotificationEnabled()) {
-    // For message center create a non-HTML notification with |icon|.
-    Notification notification(origin_url, icon, title, message,
-                              blink::WebTextDirectionDefault,
-                              base::string16(), replace_id, delegate);
-    g_browser_process->notification_ui_manager()->Add(notification, profile);
-    return notification.notification_id();
-  }
-
-  GURL icon_url;
-  if (!icon.IsEmpty())
-    icon_url = GURL(webui::GetBitmapDataUrl(*icon.ToSkBitmap()));
-  return AddNotification(
-      origin_url, title, message, icon_url, replace_id, delegate, profile);
-}
-
-// static
-void DesktopNotificationService::RemoveNotification(
-    const std::string& notification_id) {
-    g_browser_process->notification_ui_manager()->CancelById(notification_id);
+  Notification notification(origin_url, icon, title, message,
+                            blink::WebTextDirectionDefault,
+                            base::string16(), replace_id, delegate);
+  g_browser_process->notification_ui_manager()->Add(notification, profile);
+  return notification.notification_id();

[stevenjb, 2014/04/10 17:32:03]

It looks like we only call this twice, we could just embed thus code directly
and  remove the wrapper. (Not necessary though if you don't want to add to this
CL)

[jam, 2014/04/10 20:10:00]

yeah i'd prefer to keep it as simple as possible :)

 }
 
 DesktopNotificationService::DesktopNotificationService(
     Profile* profile,
     NotificationUIManager* ui_manager)
     : profile_(profile),
       ui_manager_(ui_manager) {
   OnStringListPrefChanged(
       prefs::kMessageCenterDisabledExtensionIds, &disabled_extension_ids_);
   OnStringListPrefChanged(
@@ skipping 176 matching lines @@
   // The webkit notification doesn't timeout.
   notification.set_never_timeout(true);
 
   ShowNotification(notification);
   return true;
 }
 
 base::string16 DesktopNotificationService::DisplayNameForOriginInProcessId(
     const GURL& origin, int process_id) {
   // If the source is an extension, lookup the display name.
-  // Message center prefers to use extension name if the notification
-  // is allowed by an extension.
-  if (NotificationUIManager::DelegatesToMessageCenter() ||
-      origin.SchemeIs(extensions::kExtensionScheme)) {
+  if (origin.SchemeIs(extensions::kExtensionScheme)) {
     extensions::InfoMap* extension_info_map =
         extensions::ExtensionSystem::Get(profile_)->info_map();
     if (extension_info_map) {
       extensions::ExtensionSet extensions;
       extension_info_map->GetExtensionsWithAPIPermissionForSecurityOrigin(
           origin, process_id, extensions::APIPermission::kNotification,
           &extensions);
       for (extensions::ExtensionSet::const_iterator iter = extensions.begin();
            iter != extensions.end(); ++iter) {
         NotifierId notifier_id(NotifierId::APPLICATION, (*iter)->id());
@@ skipping 87 matching lines @@
     // AppendIfNotPresent will delete |adding_value| when the same value
     // already exists.
     list->AppendIfNotPresent(id.release());
   } else {
     list->Remove(*id, NULL);
   }
 }
 
 void DesktopNotificationService::ShowWelcomeNotificationIfNecessary(
     const Notification& notification) {
-  if (!chrome_now_welcome_notification_ &&
-      message_center::IsRichNotificationEnabled()) {
+  if (!chrome_now_welcome_notification_) {
     chrome_now_welcome_notification_ =
         ExtensionWelcomeNotification::Create(kChromeNowExtensionID, profile_);
   }
 
   if (chrome_now_welcome_notification_) {
     chrome_now_welcome_notification_->ShowWelcomeNotificationIfNecessary(
         notification);
   }
 }
 
@@ skipping 50 matching lines @@
   // Tell the IO thread that this extension's permission for notifications
   // has changed.
   extensions::InfoMap* extension_info_map =
       extensions::ExtensionSystem::Get(profile_)->info_map();
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&extensions::InfoMap::SetNotificationsDisabled,
                  extension_info_map, notifier_id.id, !enabled));
 
 }