Don't include headers from the layout API from other headers needlessly.

Don't include headers from the layout API from other headers needlessly.

Including layout API headers involves including some LayoutObject derivate,
which takes a lot of time to compile.

R=bashi@chromium.org,dsinclair@chromium.org,haraken@chromium.org,bokan@chromium.org,pilgrim@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/cfeb805b47e985dd1dbff13efb499753d4f70cbf
Cr-Commit-Position: refs/heads/master@{#417265}

[mstensho (USE GERRIT), 2016-09-06 20:37:57]

Description was changed from

==========
Don't include headers from the layout API from other headers needlessly.

Including layout API headers involves including some LayoutObject derivate,
which takes a lot of time to compile.

R=bashi@chromium.org,dsinclair@chromium.org,haraken@chromium.org,bokan@chromi...
==========

to

==========
Don't include headers from the layout API from other headers needlessly.

Including layout API headers involves including some LayoutObject derivate,
which takes a lot of time to compile.

R=bashi@chromium.org,dsinclair@chromium.org,haraken@chromium.org,bokan@chromi...
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[haraken, 2016-09-07 00:40:56]

Owner LGTM

Please wait for a stamp from one of the layout reviewers.

[mstensho (USE GERRIT), 2016-09-07 05:22:52]

Description was changed from

==========
Don't include headers from the layout API from other headers needlessly.

Including layout API headers involves including some LayoutObject derivate,
which takes a lot of time to compile.

R=bashi@chromium.org,dsinclair@chromium.org,haraken@chromium.org,bokan@chromi...
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't include headers from the layout API from other headers needlessly.

Including layout API headers involves including some LayoutObject derivate,
which takes a lot of time to compile.

R=bashi@chromium.org,dsinclair@chromium.org,haraken@chromium.org,bokan@chromi...
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[mstensho (USE GERRIT), 2016-09-07 05:22:53]

mstensho@opera.com changed reviewers:
+ pilgrim@chromium.org

[mstensho (USE GERRIT), 2016-09-07 05:23:35]

Thanks. Added pilgrim too, just like I meant to do (but forgot) in the first
place.

[mstensho (USE GERRIT), 2016-09-07 06:49:47]

On my computer, this CL makes a release build from scratch 5.5% faster.

The huge gain, though, is when you modify some layout header and don't have to
recompile 1400 files, but rather 750, or even less, depending on which header
you're modifying. Traditionally, e.g. LayoutBlockFlow.h was included by around
300 compilation units, so having to recompile 1400 files vs. having to recompile
300 files is a big difference.

[bokan, 2016-09-07 16:19:06]

bokan@chromium.org changed reviewers:
+ eae@chromium.org

[bokan, 2016-09-07 16:19:06]

Changes lgtm but I'm not on the layout team. +eae@

[eae, 2016-09-08 07:51:14]

LGTM

[eae, 2016-09-08 07:51:27]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-09-08 07:51:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 07:54:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 07:54:41]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mstensho (USE GERRIT), 2016-09-08 09:07:36]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2016-09-08 09:07:36]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org,
bokan@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2316533004/#ps40001
(title: "rebase master")

[commit-bot: I haz the power, 2016-09-08 09:07:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 09:11:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 09:11:42]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mstensho (USE GERRIT), 2016-09-08 09:33:46]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-09-08 09:34:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 09:46:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 09:46:14]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[mstensho (USE GERRIT), 2016-09-08 11:08:40]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2016-09-08 11:08:41]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org,
bokan@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2316533004/#ps60001
(title: "The runway sure is slippery today.")

[commit-bot: I haz the power, 2016-09-08 11:08:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 12:54:15]

Description was changed from

==========
Don't include headers from the layout API from other headers needlessly.

Including layout API headers involves including some LayoutObject derivate,
which takes a lot of time to compile.

R=bashi@chromium.org,dsinclair@chromium.org,haraken@chromium.org,bokan@chromi...
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't include headers from the layout API from other headers needlessly.

Including layout API headers involves including some LayoutObject derivate,
which takes a lot of time to compile.

R=bashi@chromium.org,dsinclair@chromium.org,haraken@chromium.org,bokan@chromi...
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-09-08 12:54:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-08 12:56:33]

Description was changed from

==========
Don't include headers from the layout API from other headers needlessly.

Including layout API headers involves including some LayoutObject derivate,
which takes a lot of time to compile.

R=bashi@chromium.org,dsinclair@chromium.org,haraken@chromium.org,bokan@chromi...
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't include headers from the layout API from other headers needlessly.

Including layout API headers involves including some LayoutObject derivate,
which takes a lot of time to compile.

R=bashi@chromium.org,dsinclair@chromium.org,haraken@chromium.org,bokan@chromi...
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/cfeb805b47e985dd1dbff13efb499753d4f70cbf
Cr-Commit-Position: refs/heads/master@{#417265}
==========

[commit-bot: I haz the power, 2016-09-08 12:56:35]

Patchset 4 (id:??) landed as
https://crrev.com/cfeb805b47e985dd1dbff13efb499753d4f70cbf
Cr-Commit-Position: refs/heads/master@{#417265}