Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2316533004: Don't include headers from the layout API from other headers needlessly. (Closed)

Created:
4 years, 3 months ago by mstensho (USE GERRIT)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, nzolghadr+blinkwatch_chromium.org, dshwang, eae+blinkwatch, fs, dcheng, dmazzoni+watch_chromium.org, kinuko+worker_chromium.org, kinuko+watch, kouhei+svg_chromium.org, rwlbuis, falken, krit, aboxhall, aboxhall+watch_chromium.org, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, je_julie, blink-reviews-bindings_chromium.org, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, gyuyoung2, pdr+svgwatchlist_chromium.org, blink-worker-reviews_chromium.org, kenneth.christiansen, zoltan1, blink-reviews-layout_chromium.org, sof, yuzo+watch_chromium.org, dmazzoni, dtapuska+blinkwatch_chromium.org, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, nektar+watch_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, blink-layers+watch_chromium.org, nektarios, f(malita), dtseng+watch_chromium.org, horo+watch_chromium.org, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't include headers from the layout API from other headers needlessly. Including layout API headers involves including some LayoutObject derivate, which takes a lot of time to compile. R=bashi@chromium.org,dsinclair@chromium.org,haraken@chromium.org,bokan@chromium.org,pilgrim@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/cfeb805b47e985dd1dbff13efb499753d4f70cbf Cr-Commit-Position: refs/heads/master@{#417265}

Patch Set 1 #

Patch Set 2 : Forgot the unit tests. #

Patch Set 3 : rebase master #

Patch Set 4 : The runway sure is slippery today. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -17 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretBase.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.h View 3 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.cpp View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 4 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameViewAutoSizeInfo.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrame.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandlingUtil.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/ScrollManager.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImage.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPart.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAnchor.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LayerClipRecorderTest.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainterTest.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ThemePainter.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/Worklet.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorklet.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/RootScrollerTest.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TouchActionTest.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (15 generated)
mstensho (USE GERRIT)
4 years, 3 months ago (2016-09-06 20:41:38 UTC) #2
haraken
Owner LGTM Please wait for a stamp from one of the layout reviewers.
4 years, 3 months ago (2016-09-07 00:40:56 UTC) #3
mstensho (USE GERRIT)
Thanks. Added pilgrim too, just like I meant to do (but forgot) in the first ...
4 years, 3 months ago (2016-09-07 05:23:35 UTC) #6
mstensho (USE GERRIT)
On my computer, this CL makes a release build from scratch 5.5% faster. The huge ...
4 years, 3 months ago (2016-09-07 06:49:47 UTC) #7
bokan
Changes lgtm but I'm not on the layout team. +eae@
4 years, 3 months ago (2016-09-07 16:19:06 UTC) #9
eae
LGTM
4 years, 3 months ago (2016-09-08 07:51:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316533004/20001
4 years, 3 months ago (2016-09-08 07:51:55 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/292677)
4 years, 3 months ago (2016-09-08 07:54:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316533004/40001
4 years, 3 months ago (2016-09-08 09:07:53 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/138105) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-09-08 09:11:42 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316533004/40001
4 years, 3 months ago (2016-09-08 09:34:02 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/196592) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
4 years, 3 months ago (2016-09-08 09:46:14 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316533004/60001
4 years, 3 months ago (2016-09-08 11:08:56 UTC) #26
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-08 12:54:17 UTC) #28
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 12:56:35 UTC) #30
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cfeb805b47e985dd1dbff13efb499753d4f70cbf
Cr-Commit-Position: refs/heads/master@{#417265}

Powered by Google App Engine
This is Rietveld 408576698