Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: third_party/WebKit/Source/core/frame/Frame.h

Issue 2316533004: Don't include headers from the layout API from other headers needlessly. (Closed)
Patch Set: The runway sure is slippery today. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
(...skipping 12 matching lines...) Expand all
23 * along with this library; see the file COPYING.LIB. If not, write to 23 * along with this library; see the file COPYING.LIB. If not, write to
24 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 24 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
25 * Boston, MA 02110-1301, USA. 25 * Boston, MA 02110-1301, USA.
26 */ 26 */
27 27
28 #ifndef Frame_h 28 #ifndef Frame_h
29 #define Frame_h 29 #define Frame_h
30 30
31 #include "core/CoreExport.h" 31 #include "core/CoreExport.h"
32 #include "core/frame/FrameTypes.h" 32 #include "core/frame/FrameTypes.h"
33 #include "core/layout/api/LayoutPartItem.h"
34 #include "core/loader/FrameLoaderTypes.h" 33 #include "core/loader/FrameLoaderTypes.h"
35 #include "core/page/FrameTree.h" 34 #include "core/page/FrameTree.h"
36 #include "platform/heap/Handle.h" 35 #include "platform/heap/Handle.h"
37 #include "wtf/Forward.h" 36 #include "wtf/Forward.h"
38 37
39 namespace blink { 38 namespace blink {
40 39
41 class ChromeClient; 40 class ChromeClient;
42 class DOMWindow; 41 class DOMWindow;
43 class DOMWrapperWorld; 42 class DOMWrapperWorld;
44 class Document; 43 class Document;
45 class FrameClient; 44 class FrameClient;
46 class FrameHost; 45 class FrameHost;
47 class FrameOwner; 46 class FrameOwner;
48 class HTMLFrameOwnerElement; 47 class HTMLFrameOwnerElement;
49 class LayoutPart; 48 class LayoutPart;
49 class LayoutPartItem;
50 class KURL; 50 class KURL;
51 class Page; 51 class Page;
52 class SecurityContext; 52 class SecurityContext;
53 class Settings; 53 class Settings;
54 class WindowProxy; 54 class WindowProxy;
55 class WindowProxyManager; 55 class WindowProxyManager;
56 struct FrameLoadRequest; 56 struct FrameLoadRequest;
57 57
58 enum class FrameDetachType { Remove, Swap }; 58 enum class FrameDetachType { Remove, Swap };
59 59
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 // Returns true if the frame is ready to receive the next commit, or false 113 // Returns true if the frame is ready to receive the next commit, or false
114 // otherwise. 114 // otherwise.
115 virtual bool prepareForCommit() = 0; 115 virtual bool prepareForCommit() = 0;
116 116
117 bool canNavigate(const Frame&); 117 bool canNavigate(const Frame&);
118 virtual void printNavigationErrorMessage(const Frame&, const char* reason) = 0; 118 virtual void printNavigationErrorMessage(const Frame&, const char* reason) = 0;
119 119
120 // TODO(pilgrim) replace all instances of ownerLayoutObject() with ownerLayo utItem() 120 // TODO(pilgrim) replace all instances of ownerLayoutObject() with ownerLayo utItem()
121 // https://crbug.com/499321 121 // https://crbug.com/499321
122 LayoutPart* ownerLayoutObject() const; // LayoutObject for the element that contains this frame. 122 LayoutPart* ownerLayoutObject() const; // LayoutObject for the element that contains this frame.
123 LayoutPartItem ownerLayoutItem() const 123 LayoutPartItem ownerLayoutItem() const;
124 {
125 return LayoutPartItem(this->ownerLayoutObject());
126 }
127 124
128 Settings* settings() const; // can be null 125 Settings* settings() const; // can be null
129 126
130 // isLoading() is true when the embedder should think a load is in progress. 127 // isLoading() is true when the embedder should think a load is in progress.
131 // In the case of LocalFrames, it means that the frame has sent a didStartLo ading() 128 // In the case of LocalFrames, it means that the frame has sent a didStartLo ading()
132 // callback, but not the matching didStopLoading(). Inside blink, you probab ly 129 // callback, but not the matching didStopLoading(). Inside blink, you probab ly
133 // want Document::loadEventFinished() instead. 130 // want Document::loadEventFinished() instead.
134 void setIsLoading(bool isLoading) { m_isLoading = isLoading; } 131 void setIsLoading(bool isLoading) { m_isLoading = isLoading; }
135 bool isLoading() const { return m_isLoading; } 132 bool isLoading() const { return m_isLoading; }
136 133
(...skipping 30 matching lines...) Expand all
167 { 164 {
168 return m_treeNode; 165 return m_treeNode;
169 } 166 }
170 167
171 // Allow equality comparisons of Frames by reference or pointer, interchangeably . 168 // Allow equality comparisons of Frames by reference or pointer, interchangeably .
172 DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES(Frame) 169 DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES(Frame)
173 170
174 } // namespace blink 171 } // namespace blink
175 172
176 #endif // Frame_h 173 #endif // Frame_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelection.cpp ('k') | third_party/WebKit/Source/core/frame/Frame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698