build/android/gyp/util/build_utils.py - Issue 2315993003: Reland of GN(Android): Stop specifying depfile under outputs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/util/build_utils.py

Issue 2315993003: Reland of GN(Android): Stop specifying depfile under outputs (Closed)

Patch Set: Create depfile parent directory when it doesn't exist Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/util/build_utils.py

diff --git a/build/android/gyp/util/build_utils.py b/build/android/gyp/util/build_utils.py

index d2ae39fb2ba16add4978d08e0356c850e32ced61..8b374e6f11ecabe33a89201e169d2a6436f40e90 100644

--- a/build/android/gyp/util/build_utils.py

+++ b/build/android/gyp/util/build_utils.py

@@ -424,6 +424,7 @@ def AddDepfileOption(parser):

def WriteDepfile(path, dependencies):

+ MakeDirectory(os.path.dirname(path))

with open(path, 'w') as depfile:

depfile.write(path)

depfile.write(': ')

« no previous file with comments | « android_webview/BUILD.gn ('k') | build/config/android/internal_rules.gni » ('j') | no next file with comments »