Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2315323002: Pass JavaRef to WebContents::FromJavaWebContents. (Closed)

Created:
4 years, 3 months ago by Torne
Modified:
4 years, 3 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, donnd+watch_chromium.org, jam, twellington+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass JavaRef to WebContents::FromJavaWebContents. Update WebContents::FromJavaWebContents to use JavaRef instead of bare jobject. Various function parameter types are converted from jobject to JavaRef to enable calls to obj() higher up the call chain to be removed. Also, fix a few similar cases that just happen to be in the same files as files already being modified, to avoid touching them again in a later CL. BUG=506850 Committed: https://crrev.com/b5fe8a62b9b232e9f003d28d9cacb77378b6d4e2 Cr-Commit-Position: refs/heads/master@{#417260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -33 lines) Patch
M chrome/browser/android/contextualsearch/contextual_search_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/contextualsearch/contextual_search_manager.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/android/find_in_page/find_in_page_bridge.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/android/find_in_page/find_in_page_bridge.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/android/tab_android.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/android/tab_state.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_promo_infobar_delegate_android.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_promo_infobar_delegate_android.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/android/toolbar/toolbar_model_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Torne
OWNERS: tedchoc: chrome jochen: content
4 years, 3 months ago (2016-09-07 14:00:50 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-07 14:27:52 UTC) #3
Ted C
lgtm
4 years, 3 months ago (2016-09-07 17:34:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315323002/1
4 years, 3 months ago (2016-09-08 10:34:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 12:01:11 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 12:03:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5fe8a62b9b232e9f003d28d9cacb77378b6d4e2
Cr-Commit-Position: refs/heads/master@{#417260}

Powered by Google App Engine
This is Rietveld 408576698