Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: chrome/browser/android/find_in_page/find_in_page_bridge.cc

Issue 2315323002: Pass JavaRef to WebContents::FromJavaWebContents. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/find_in_page/find_in_page_bridge.h" 5 #include "chrome/browser/android/find_in_page/find_in_page_bridge.h"
6 6
7 #include "base/android/jni_string.h" 7 #include "base/android/jni_string.h"
8 #include "chrome/browser/ui/find_bar/find_tab_helper.h" 8 #include "chrome/browser/ui/find_bar/find_tab_helper.h"
9 #include "content/public/browser/web_contents.h" 9 #include "content/public/browser/web_contents.h"
10 #include "jni/FindInPageBridge_jni.h" 10 #include "jni/FindInPageBridge_jni.h"
11 11
12 using base::android::ConvertUTF16ToJavaString; 12 using base::android::ConvertUTF16ToJavaString;
13 using base::android::JavaParamRef; 13 using base::android::JavaParamRef;
14 using base::android::JavaRef;
14 using base::android::ScopedJavaLocalRef; 15 using base::android::ScopedJavaLocalRef;
15 16
16 FindInPageBridge::FindInPageBridge(JNIEnv* env, 17 FindInPageBridge::FindInPageBridge(JNIEnv* env,
17 jobject obj, 18 const JavaRef<jobject>& obj,
18 jobject j_web_contents) 19 const JavaRef<jobject>& j_web_contents)
19 : weak_java_ref_(env, obj) { 20 : weak_java_ref_(env, obj) {
20 web_contents_ = content::WebContents::FromJavaWebContents(j_web_contents); 21 web_contents_ = content::WebContents::FromJavaWebContents(j_web_contents);
21 } 22 }
22 23
23 void FindInPageBridge::Destroy(JNIEnv*, const JavaParamRef<jobject>&) { 24 void FindInPageBridge::Destroy(JNIEnv*, const JavaParamRef<jobject>&) {
24 delete this; 25 delete this;
25 } 26 }
26 27
27 void FindInPageBridge::StartFinding(JNIEnv* env, 28 void FindInPageBridge::StartFinding(JNIEnv* env,
28 const JavaParamRef<jobject>& obj, 29 const JavaParamRef<jobject>& obj,
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 static jlong Init(JNIEnv* env, 79 static jlong Init(JNIEnv* env,
79 const JavaParamRef<jobject>& obj, 80 const JavaParamRef<jobject>& obj,
80 const JavaParamRef<jobject>& j_web_contents) { 81 const JavaParamRef<jobject>& j_web_contents) {
81 FindInPageBridge* bridge = new FindInPageBridge(env, obj, j_web_contents); 82 FindInPageBridge* bridge = new FindInPageBridge(env, obj, j_web_contents);
82 return reinterpret_cast<intptr_t>(bridge); 83 return reinterpret_cast<intptr_t>(bridge);
83 } 84 }
84 85
85 bool FindInPageBridge::RegisterFindInPageBridge(JNIEnv* env) { 86 bool FindInPageBridge::RegisterFindInPageBridge(JNIEnv* env) {
86 return RegisterNativesImpl(env); 87 return RegisterNativesImpl(env);
87 } 88 }
OLDNEW
« no previous file with comments | « chrome/browser/android/find_in_page/find_in_page_bridge.h ('k') | chrome/browser/android/tab_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698