chrome/browser/net/spdyproxy/data_reduction_promo_infobar_delegate_android.cc - Issue 2315323002: Pass JavaRef to WebContents::FromJavaWebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/spdyproxy/data_reduction_promo_infobar_delegate_android.cc

Issue 2315323002: Pass JavaRef to WebContents::FromJavaWebContents. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/spdyproxy/data_reduction_promo_infobar_delegate_android.h ('k') | chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/spdyproxy/data_reduction_promo_infobar_delegate_android.cc

diff --git a/chrome/browser/net/spdyproxy/data_reduction_promo_infobar_delegate_android.cc b/chrome/browser/net/spdyproxy/data_reduction_promo_infobar_delegate_android.cc

index 48933886f4ee2f653b5228ef7e0db224feff813e..6f31964df9ba1f79c2bf9177516d5f666ea2722f 100644

--- a/chrome/browser/net/spdyproxy/data_reduction_promo_infobar_delegate_android.cc

+++ b/chrome/browser/net/spdyproxy/data_reduction_promo_infobar_delegate_android.cc

@@ -11,6 +11,7 @@

#include "jni/DataReductionPromoInfoBarDelegate_jni.h"

using base::android::JavaParamRef;

+using base::android::JavaRef;

// static

void DataReductionPromoInfoBarDelegateAndroid::Create(

@@ -39,7 +40,8 @@ bool DataReductionPromoInfoBarDelegateAndroid::Register(JNIEnv* env) {

// static

void DataReductionPromoInfoBarDelegateAndroid::Launch(

- JNIEnv* env, jclass, jobject jweb_contents) {

+ JNIEnv* env,

+ const JavaRef<jobject>& jweb_contents) {

content::WebContents* web_contents =

content::WebContents::FromJavaWebContents(jweb_contents);

DCHECK(web_contents);

@@ -72,5 +74,5 @@ bool DataReductionPromoInfoBarDelegateAndroid::Accept() {

void Launch(JNIEnv* env,

const JavaParamRef<jclass>& clazz,

const JavaParamRef<jobject>& jweb_contents) {

- DataReductionPromoInfoBarDelegateAndroid::Launch(env, clazz, jweb_contents);

+ DataReductionPromoInfoBarDelegateAndroid::Launch(env, jweb_contents);

}