chrome/browser/android/find_in_page/find_in_page_bridge.h - Issue 2315323002: Pass JavaRef to WebContents::FromJavaWebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/find_in_page/find_in_page_bridge.h

Issue 2315323002: Pass JavaRef to WebContents::FromJavaWebContents. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/find_in_page/find_in_page_bridge.h

diff --git a/chrome/browser/android/find_in_page/find_in_page_bridge.h b/chrome/browser/android/find_in_page/find_in_page_bridge.h

index fea098adcb2d4754a9ae927f6b707e3cfb0fa45f..3836c7b084442fa074ad276d849add81817f9f48 100644

--- a/chrome/browser/android/find_in_page/find_in_page_bridge.h

+++ b/chrome/browser/android/find_in_page/find_in_page_bridge.h

@@ -13,7 +13,9 @@

class FindInPageBridge {

public:

- FindInPageBridge(JNIEnv* env, jobject obj, jobject j_web_contents);

+ FindInPageBridge(JNIEnv* env,

+ const base::android::JavaRef<jobject>& obj,

+ const base::android::JavaRef<jobject>& j_web_contents);

void Destroy(JNIEnv*, const base::android::JavaParamRef<jobject>&);

void StartFinding(JNIEnv* env,