Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2315223004: Fix P2PSocketHostUdp to handle dropped packets properly. (Closed)

Created:
4 years, 3 months ago by Sergey Ulanov
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Fix P2PSocketHostUdp to handle dropped packets properly. P2PSocketHostUdp may drop outgoing packets to throttle unauthenticated outgoing STUN requests. Previously it wasn't sending OnSendComplete message for these packets, which causes crash in the renderer. Also fixed another potential crashed in the same class. BUG=630984 Review-Url: https://codereview.chromium.org/2300983003 Cr-Commit-Position: refs/heads/master@{#416316} (cherry picked from commit 8da820dbc74943aefc6607b10eb2804547b57926) Committed: https://chromium.googlesource.com/chromium/src/+/e245af07b7c278917d15ef66bba9840732a3eb11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -22 lines) Patch
M content/browser/renderer_host/p2p/socket_host_udp.cc View 4 chunks +31 lines, -20 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Sergey Ulanov
4 years, 3 months ago (2016-09-07 22:22:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e245af07b7c278917d15ef66bba9840732a3eb11.

Powered by Google App Engine
This is Rietveld 408576698