Fix P2PSocketHostUdp to handle dropped packets properly.

content/browser/renderer_host/p2p/socket_host_udp_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/p2p/socket_host_udp.h"
 
 #include <stdint.h>
 #include <deque>
 #include <utility>
 #include <vector>
@@ skipping 337 matching lines @@
       .WillOnce(DoAll(DeleteArg<0>(), Return(true)));
   socket_host_->Send(dest2_, packet, options, 0);
 }
 
 // Verify throttler not allowing unlimited sending of ICE messages to
 // any destination.
 TEST_F(P2PSocketHostUdpTest, ThrottleAfterLimit) {
   EXPECT_CALL(
       sender_,
       Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnSendComplete::ID))))
-      .Times(2)
+      .Times(3)
       .WillRepeatedly(DoAll(DeleteArg<0>(), Return(true)));
 
   rtc::PacketOptions options;
   std::vector<char> packet1;
   CreateStunRequest(&packet1);
   throttler_.SetSendIceBandwidth(packet1.size() * 2);
   socket_host_->Send(dest1_, packet1, options, 0);
   socket_host_->Send(dest2_, packet1, options, 0);
 
   net::IPEndPoint dest3 = ParseAddress(kTestIpAddress1, 2222);
   // This packet must be dropped by the throttler.
   socket_host_->Send(dest3, packet1, options, 0);
   ASSERT_EQ(sent_packets_.size(), 2U);
 }
 
 // Verify we can send packets to a known destination when ICE throttling is
 // active.
 TEST_F(P2PSocketHostUdpTest, ThrottleAfterLimitAfterReceive) {
   // Receive packet from |dest1_|.
   std::vector<char> request_packet;
   CreateStunRequest(&request_packet);
 
   EXPECT_CALL(sender_, Send(MatchPacketMessage(request_packet)))
       .WillOnce(DoAll(DeleteArg<0>(), Return(true)));
   socket_->ReceivePacket(dest1_, request_packet);
 
   EXPECT_CALL(
       sender_,
       Send(MatchMessage(static_cast<uint32_t>(P2PMsg_OnSendComplete::ID))))
-      .Times(4)
+      .Times(6)
       .WillRepeatedly(DoAll(DeleteArg<0>(), Return(true)));
 
   rtc::PacketOptions options;
   std::vector<char> packet1;
   CreateStunRequest(&packet1);
   throttler_.SetSendIceBandwidth(packet1.size());
   // |dest1_| is known address, throttling will not be applied.
   socket_host_->Send(dest1_, packet1, options, 0);
   // Trying to send the packet to dest1_ in the same window. It should go.
   socket_host_->Send(dest1_, packet1, options, 0);
@@ skipping 103 matching lines @@
   std::unique_ptr<P2PSocketHostUdp> socket_host(
       new P2PSocketHostUdp(&sender, 0, &throttler, fake_socket_factory));
   net::IPEndPoint local_address =
       ParseAddress(kTestLocalIpAddress, invalid_port);
   bool rv = socket_host->Init(local_address, min_port, max_port,
                               P2PHostAndIPEndPoint());
   EXPECT_FALSE(rv);
 }
 
 }  // namespace content