Fix P2PSocketHostUdp to handle dropped packets properly.

Fix P2PSocketHostUdp to handle dropped packets properly.

P2PSocketHostUdp may drop outgoing packets to throttle
unauthenticated outgoing STUN requests. Previously it wasn't sending
OnSendComplete message for these packets, which causes crash in the
renderer.

Also fixed another potential crashed in the same class.

BUG=630984
Committed: https://crrev.com/8da820dbc74943aefc6607b10eb2804547b57926
Cr-Commit-Position: refs/heads/master@{#416316}

[Sergey Ulanov, 2016-09-02 00:34:51]

Description was changed from

==========
Fix P2PSocketHostUdp to handle dropped packets properly.

P2PSocketHostUdp may drop outgoing packets to throttle
unauthenticated outgoing STUN requests. Previously it wasn't sending
OnSendComplete message for these packets, which causes crash in the
renderer.

BUG=630984
==========

to

==========
Fix P2PSocketHostUdp to handle dropped packets properly.

P2PSocketHostUdp may drop outgoing packets to throttle
unauthenticated outgoing STUN requests. Previously it wasn't sending
OnSendComplete message for these packets, which causes crash in the
renderer.

Also fixed another potential crashed in the same class.

BUG=630984
==========

[Sergey Ulanov, 2016-09-02 00:36:19]

sergeyu@chromium.org changed reviewers:
+ guidou@chromium.org

[Sergey Ulanov, 2016-09-02 00:36:19]

Sending this to you because you made some changes in this directory fairly
recently.

[pthatcher2, 2016-09-02 05:21:18]

pthatcher@chromium.org changed reviewers:
+ pthatcher@chromium.org

[pthatcher2, 2016-09-02 05:21:19]

lgtm

https://codereview.chromium.org/2300983003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/p2p/socket_host_udp.cc (right):

https://codereview.chromium.org/2300983003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/p2p/socket_host_udp.cc:303: send_time)));
We should leave a comment about how important it is to keep this here to make
sure we don't break it again by refactoring it.

[Guido Urdaneta, 2016-09-02 09:23:15]

lgtm

[Sergey Ulanov, 2016-09-02 17:00:46]

https://codereview.chromium.org/2300983003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/p2p/socket_host_udp.cc (right):

https://codereview.chromium.org/2300983003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/p2p/socket_host_udp.cc:303: send_time)));
On 2016/09/02 05:21:19, pthatcher2 wrote:
> We should leave a comment about how important it is to keep this here to make
> sure we don't break it again by refactoring it.

Done.

[Sergey Ulanov, 2016-09-02 17:10:40]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-09-02 17:10:40]

The patchset sent to the CQ was uploaded after l-g-t-m from guidou@chromium.org,
pthatcher@chromium.org
Link to the patchset: https://codereview.chromium.org/2300983003/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2016-09-02 17:11:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 17:28:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 17:28:23]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Sergey Ulanov, 2016-09-02 17:47:56]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-09-02 17:47:56]

The patchset sent to the CQ was uploaded after l-g-t-m from guidou@chromium.org,
pthatcher@chromium.org
Link to the patchset: https://codereview.chromium.org/2300983003/#ps40001
(title: "update unittests")

[commit-bot: I haz the power, 2016-09-02 17:48:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 19:10:36]

Description was changed from

==========
Fix P2PSocketHostUdp to handle dropped packets properly.

P2PSocketHostUdp may drop outgoing packets to throttle
unauthenticated outgoing STUN requests. Previously it wasn't sending
OnSendComplete message for these packets, which causes crash in the
renderer.

Also fixed another potential crashed in the same class.

BUG=630984
==========

to

==========
Fix P2PSocketHostUdp to handle dropped packets properly.

P2PSocketHostUdp may drop outgoing packets to throttle
unauthenticated outgoing STUN requests. Previously it wasn't sending
OnSendComplete message for these packets, which causes crash in the
renderer.

Also fixed another potential crashed in the same class.

BUG=630984
==========

[commit-bot: I haz the power, 2016-09-02 19:10:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-02 19:13:39]

Description was changed from

==========
Fix P2PSocketHostUdp to handle dropped packets properly.

P2PSocketHostUdp may drop outgoing packets to throttle
unauthenticated outgoing STUN requests. Previously it wasn't sending
OnSendComplete message for these packets, which causes crash in the
renderer.

Also fixed another potential crashed in the same class.

BUG=630984
==========

to

==========
Fix P2PSocketHostUdp to handle dropped packets properly.

P2PSocketHostUdp may drop outgoing packets to throttle
unauthenticated outgoing STUN requests. Previously it wasn't sending
OnSendComplete message for these packets, which causes crash in the
renderer.

Also fixed another potential crashed in the same class.

BUG=630984

Committed: https://crrev.com/8da820dbc74943aefc6607b10eb2804547b57926
Cr-Commit-Position: refs/heads/master@{#416316}
==========

[commit-bot: I haz the power, 2016-09-02 19:13:40]

Patchset 3 (id:??) landed as
https://crrev.com/8da820dbc74943aefc6607b10eb2804547b57926
Cr-Commit-Position: refs/heads/master@{#416316}