Improve download recovery flow:

Improve download recovery flow:

(1) refine strings in download recovery dialog
(2) remove all message leads, and keep title and message body to simply
    previously lengthy text in download recovery dialog
(3) refine description strings that used to explain the reason why download
    is blocked in chrome://downloads (text in orange)
(4) If download danger type is DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE, when user
    try to recover a blocked download, directly proceed instead of showing
    download danger prompt.
go/fix_download_recovery  for more detail

BUG=640673
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f857966ed00a2e7703f98f901d28ae3677592341
Cr-Commit-Position: refs/heads/master@{#418340}

[Jialiu Lin, 2016-09-06 17:51:22]

Description was changed from

==========
Improve download recovery flow:

(1) refine strings in download recovery dialog
(2) remove all message leads, and keep title and message body to simply
    previously lengthy text in download recovery dialog
(3) refine description strings that used to explain the reason why download
    is blocked in chrome://downloads (text in orange)
(4) If download danger type is DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE, when user
    try to recover a blocked download, directly proceed instead of showing
    download danger prompt.
go/fix_download_recovery  for more detail

BUG=640673
==========

to

==========
Improve download recovery flow:

(1) refine strings in download recovery dialog
(2) remove all message leads, and keep title and message body to simply
    previously lengthy text in download recovery dialog
(3) refine description strings that used to explain the reason why download
    is blocked in chrome://downloads (text in orange)
(4) If download danger type is DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE, when user
    try to recover a blocked download, directly proceed instead of showing
    download danger prompt.
go/fix_download_recovery  for more detail

BUG=640673
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Jialiu Lin, 2016-09-06 17:51:37]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 17:52:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2016-09-06 18:26:29]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 18:26:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 19:51:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 19:51:02]

Dry run: This issue passed the CQ dry run.

[Jialiu Lin, 2016-09-06 20:00:52]

jialiul@chromium.org changed reviewers:
+ cpu@chromium.org

[Jialiu Lin, 2016-09-06 20:00:53]

Hi cpu@, 
Could you take a look at all the string changes in chrome/app/*?  This is my
first time changing *.grd files, let me know if I missed any guidelines.

The overall issue is described in go/fix_download_recovery doc. This change was
approved by chrome UX/UI review. 

Thanks!

[Jialiu Lin, 2016-09-07 17:41:22]

jialiul@chromium.org changed reviewers:
+ dbeam@chromium.org

[Jialiu Lin, 2016-09-07 17:41:23]

+dbean@,
Hi dbean@, 
Could you take a look at files under chrome/browser/resources/md_downloads/ and
chrome/browser/ui/webui/md_downloads directories ?
Change has approved by UX review, its detail summarized in
go/fix_download_recovery

Thanks!

[Dan Beam, 2016-09-08 02:31:28]

lgtm

https://codereview.chromium.org/2314903003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_downloads/item.js (right):

https://codereview.chromium.org/2314903003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_downloads/item.js:147: return
loadTimeData.getStringF('dangerFileDesc');
getStringF -> getString

https://codereview.chromium.org/2314903003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc (right):

https://codereview.chromium.org/2314903003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc:198:
HandleSaveDownload(file);
nit: maybe just do the null check inside of HandleSaveDownload()?

https://codereview.chromium.org/2314903003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc:201: void
MdDownloadsDOMHandler::HandleSaveDownload(
don't name this "Handle", that's commonly used for webui message handlers

https://codereview.chromium.org/2314903003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.h (right):

https://codereview.chromium.org/2314903003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.h:155: // User
profile correspond to this handler.
"that corresponds" or "corresponding"

https://codereview.chromium.org/2314903003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc
(right):

https://codereview.chromium.org/2314903003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc:30:
using MdDownloadsDOMHandler::HandleSaveDownload;
nit: \n

[Jialiu Lin, 2016-09-08 18:40:19]

jialiul@chromium.org changed reviewers:
+ asanka@chromium.org

[Jialiu Lin, 2016-09-08 18:40:20]

Thanks dbeam@!

+asanka@, Could you take a look at the changes in chrome/browser/download/* and
chrome/browser/ui/cocoa/download/*?   Thanks!

https://codereview.chromium.org/2314903003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_downloads/item.js (right):

https://codereview.chromium.org/2314903003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_downloads/item.js:147: return
loadTimeData.getStringF('dangerFileDesc');
On 2016/09/08 at 02:31:28, Dan Beam wrote:
> getStringF -> getString

Done for both item.js and crisper.js

https://codereview.chromium.org/2314903003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc (right):

https://codereview.chromium.org/2314903003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc:198:
HandleSaveDownload(file);
On 2016/09/08 at 02:31:28, Dan Beam wrote:
> nit: maybe just do the null check inside of HandleSaveDownload()?

done.

https://codereview.chromium.org/2314903003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc:201: void
MdDownloadsDOMHandler::HandleSaveDownload(
On 2016/09/08 at 02:31:28, Dan Beam wrote:
> don't name this "Handle", that's commonly used for webui message handlers

Done.

https://codereview.chromium.org/2314903003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.h (right):

https://codereview.chromium.org/2314903003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.h:155: // User
profile correspond to this handler.
On 2016/09/08 at 02:31:28, Dan Beam wrote:
> "that corresponds" or "corresponding"

Done.

https://codereview.chromium.org/2314903003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc
(right):

https://codereview.chromium.org/2314903003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc:30:
using MdDownloadsDOMHandler::HandleSaveDownload;
On 2016/09/08 at 02:31:28, Dan Beam wrote:
> nit: \n

Done.

[asanka, 2016-09-08 21:17:14]

LGTM % nits

https://codereview.chromium.org/2314903003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc (left):

https://codereview.chromium.org/2314903003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc:204: return
l10n_util::GetStringUTF16(IDS_CONFIRM_DOWNLOAD_AGAIN_MALICIOUS);
Here and elsewhere, could you check whether there are any uses of the strings
that this patch is moving away from? If so, we can remove the strings from the
.grd file.

https://codereview.chromium.org/2314903003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc (right):

https://codereview.chromium.org/2314903003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc:130: return
l10n_util::GetStringUTF16(IDS_DOWNLOAD_DANGEROUS_DOWNLOAD_TITLE);
FYI: The use of the strings imply that the download hasn't happened. This is not
quite accurate. The dangerous URL warning is shown to the user while the file is
being downloaded in the background into a quarantined file.

https://codereview.chromium.org/2314903003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc:205: case
content::DOWNLOAD_DANGER_TYPE_UNCOMMON_CONTENT: {
Nit : braces unnecessary. Here and elsewhere.

[Jialiu Lin, 2016-09-08 23:15:22]

jialiul@chromium.org changed reviewers:
+ msw@chromium.org

[Jialiu Lin, 2016-09-08 23:15:23]

Thanks, asanka@! Your comments are all addressed.

+ msw@, Could you take a look at
chrome/browser/ui/views/download/download_danger_prompt_views.cc 
? Same string changes as in c/b/u/cocoa/download/download_danger_prompt_impl.cc

Thanks!

https://codereview.chromium.org/2314903003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc (left):

https://codereview.chromium.org/2314903003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc:204: return
l10n_util::GetStringUTF16(IDS_CONFIRM_DOWNLOAD_AGAIN_MALICIOUS);
On 2016/09/08 at 21:17:13, asanka wrote:
> Here and elsewhere, could you check whether there are any uses of the strings
that this patch is moving away from? If so, we can remove the strings from the
.grd file.

Yes, they are removed.

https://codereview.chromium.org/2314903003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc (right):

https://codereview.chromium.org/2314903003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc:130: return
l10n_util::GetStringUTF16(IDS_DOWNLOAD_DANGEROUS_DOWNLOAD_TITLE);
On 2016/09/08 at 21:17:13, asanka wrote:
> FYI: The use of the strings imply that the download hasn't happened. This is
not quite accurate. The dangerous URL warning is shown to the user while the
file is being downloaded in the background into a quarantined file.

You're right.... It might be better to use IDS_KEEP_DANGEROUS_DOWNLOAD_TITLE
("Keep dangerous file?") for this case too. I'll update design doc.

https://codereview.chromium.org/2314903003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc:205: case
content::DOWNLOAD_DANGER_TYPE_UNCOMMON_CONTENT: {
On 2016/09/08 at 21:17:13, asanka wrote:
> Nit : braces unnecessary. Here and elsewhere.
Done.

[msw, 2016-09-08 23:33:57]

c/b/ui/views lgtm with nits

https://codereview.chromium.org/2314903003/diff/60001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc (right):

https://codereview.chromium.org/2314903003/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc:198: switch
(download_->GetDangerType()) {
nit: this switch is unnecessary, just replace it with:
  return l10n_util::GetStringUTF16(IDS_CONFIRM_DOWNLOAD_AGAIN);

https://codereview.chromium.org/2314903003/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/download/download_danger_prompt_views.cc (right):

https://codereview.chromium.org/2314903003/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/download/download_danger_prompt_views.cc:244: switch
(download_->GetDangerType()) {
ditto nit: just return l10n_util::GetStringUTF16(IDS_CONFIRM_DOWNLOAD_AGAIN);

[Jialiu Lin, 2016-09-09 00:17:46]

Thanks for catching these, msw@. Nits fixed.

cpu@, any feedback on these *grd files? Please feel free to suggest other
reviewers if you're not available. Thanks! :-)

https://codereview.chromium.org/2314903003/diff/60001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc (right):

https://codereview.chromium.org/2314903003/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc:198: switch
(download_->GetDangerType()) {
On 2016/09/08 at 23:33:57, msw wrote:
> nit: this switch is unnecessary, just replace it with:
>   return l10n_util::GetStringUTF16(IDS_CONFIRM_DOWNLOAD_AGAIN);

Oops, Thanks for catching this. Done.

https://codereview.chromium.org/2314903003/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/download/download_danger_prompt_views.cc (right):

https://codereview.chromium.org/2314903003/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/download/download_danger_prompt_views.cc:244: switch
(download_->GetDangerType()) {
On 2016/09/08 at 23:33:57, msw wrote:
> ditto nit: just return l10n_util::GetStringUTF16(IDS_CONFIRM_DOWNLOAD_AGAIN);

done. Thanks!

[msw, 2016-09-09 00:35:15]

On 2016/09/09 00:17:46, Jialiu Lin wrote:
> cpu@, any feedback on these *grd files? Please feel free to suggest other
> reviewers if you're not available. Thanks! :-)

You should probably ping grt@; Carlos has another primary project now.
Carlos, would you like to be removed from any OWNERS files?

[Jialiu Lin, 2016-09-09 00:38:08]

jialiul@chromium.org changed reviewers:
+ grt@chromium.org

[Jialiu Lin, 2016-09-09 00:39:07]

jialiul@chromium.org changed reviewers:
- cpu@chromium.org

[Jialiu Lin, 2016-09-09 00:39:38]

+grt@, could you take a look at changes in these *.grd?  Thanks!

[grt (UTC plus 2), 2016-09-12 06:44:50]

https://codereview.chromium.org/2314903003/diff/80001/chrome/app/chromium_str...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/2314903003/diff/80001/chrome/app/chromium_str...
chrome/app/chromium_strings.grd:560: desc="Message shown to the user on
chrome://downloads page to explain why this download is blocked.">
these two messages have the same description, yet different text. please be more
explicit in the descriptions so that translators have a good chance of conveying
the subtlety properly in other languages.

https://codereview.chromium.org/2314903003/diff/80001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (left):

https://codereview.chromium.org/2314903003/diff/80001/chrome/app/generated_re...
chrome/app/generated_resources.grd:1787: desc="Text for the button used to
validate the downloading of a dangerous download.">
this has the same description as the message above. please justify the
requirement for two messages rather than one in the description so that
translators can more accurately translate these to other languages.

https://codereview.chromium.org/2314903003/diff/80001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2314903003/diff/80001/chrome/app/generated_re...
chrome/app/generated_resources.grd:1777: +        Even if you have downloaded
files from this site before, the site may be temporarily unsafe (hacked). Try
downloading this file later.
Does the user get the same info if the message is "This site may be temporarily
unsafe (i.e., hacked). Try downloading this file later." I think starting with
"Even if you have..." makes the sentence harder to understand.

[Jialiu Lin, 2016-09-12 20:39:07]

Thanks, grt@! string descriptions updated.

https://codereview.chromium.org/2314903003/diff/80001/chrome/app/chromium_str...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/2314903003/diff/80001/chrome/app/chromium_str...
chrome/app/chromium_strings.grd:560: desc="Message shown to the user on
chrome://downloads page to explain why this download is blocked.">
On 2016/09/12 at 06:44:50, grt (UTC plus 2) wrote:
> these two messages have the same description, yet different text. please be
more explicit in the descriptions so that translators have a good chance of
conveying the subtlety properly in other languages.

Done, same as these strings in google_chrome_strings.grd

https://codereview.chromium.org/2314903003/diff/80001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (left):

https://codereview.chromium.org/2314903003/diff/80001/chrome/app/generated_re...
chrome/app/generated_resources.grd:1787: desc="Text for the button used to
validate the downloading of a dangerous download.">
On 2016/09/12 at 06:44:50, grt (UTC plus 2) wrote:
> this has the same description as the message above. please justify the
requirement for two messages rather than one in the description so that
translators can more accurately translate these to other languages.
Ah, good catch. They appear at different situations. The first one appears in
the download warning on the download shelf (a.k.a the warning users see when
they download a file). Due to the size limit, it only use one word.
The second one appears in chrome://downloads page where all the blocked
downloads are shown, and if user want to restore the dangerous one, they can
click this "Keep dangerous file" button. Since there is more space in
chrome://download page, we can emphasize the risk in button text.
Description updated to reflect this differences.

https://codereview.chromium.org/2314903003/diff/80001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2314903003/diff/80001/chrome/app/generated_re...
chrome/app/generated_resources.grd:1777: +        Even if you have downloaded
files from this site before, the site may be temporarily unsafe (hacked). Try
downloading this file later.
On 2016/09/12 at 06:44:50, grt (UTC plus 2) wrote:
> Does the user get the same info if the message is "This site may be
temporarily unsafe (i.e., hacked). Try downloading this file later." I think
starting with "Even if you have..." makes the sentence harder to understand.

This is shown to the user when he/she tries to recover a malicious/dangerous
download. It has a title to go with. The entire warning dialog reads like this:
"Keep dangerous file?
  Even if you have downloaded files from this site before, the site may be
temporarily unsafe (hacked). Try downloading this file later.
                 Keep anyway | Cancel 
"

This message tries to offer a possible explanation to users who visited the site
before, though we actually don't know if this site is indeed hacked or it just
decides to serve bad content one day. "This site maybe temporarily unsafe"
sounds a little bit too confident.

[grt (UTC plus 2), 2016-09-13 06:35:49]

.grd files lgtm w/ nits

https://codereview.chromium.org/2314903003/diff/80001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2314903003/diff/80001/chrome/app/generated_re...
chrome/app/generated_resources.grd:1777: +        Even if you have downloaded
files from this site before, the site may be temporarily unsafe (hacked). Try
downloading this file later.
On 2016/09/12 20:39:07, Jialiu Lin wrote:
> On 2016/09/12 at 06:44:50, grt (UTC plus 2) wrote:
> > Does the user get the same info if the message is "This site may be
> temporarily unsafe (i.e., hacked). Try downloading this file later." I think
> starting with "Even if you have..." makes the sentence harder to understand.
> 
> This is shown to the user when he/she tries to recover a malicious/dangerous
> download. It has a title to go with. The entire warning dialog reads like
this:
> "Keep dangerous file?
>   Even if you have downloaded files from this site before, the site may be
> temporarily unsafe (hacked). Try downloading this file later.
>                  Keep anyway | Cancel 
> "
> 
> This message tries to offer a possible explanation to users who visited the
site
> before, though we actually don't know if this site is indeed hacked or it just
> decides to serve bad content one day. "This site maybe temporarily unsafe"
> sounds a little bit too confident. 
> 

Acknowledged.

https://codereview.chromium.org/2314903003/diff/100001/chrome/app/chromium_st...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/2314903003/diff/100001/chrome/app/chromium_st...
chrome/app/chromium_strings.grd:560: desc="Message shown to the user on
chrome://downloads page to explain that this download is blocked because it is a
malware.">
nit: "it is malware"

https://codereview.chromium.org/2314903003/diff/100001/chrome/app/chromium_st...
chrome/app/chromium_strings.grd:564: desc="Message shown to the user on
chrome://downloads page to explain that this download is blocked because it is
an unwanted sofware.">
nit: "it is unwanted software"

[Jialiu Lin, 2016-09-13 17:35:11]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 17:35:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2016-09-13 17:36:24]

Thanks or catching these, grt@! 

Thanks all reviewers for your thorough review!

https://codereview.chromium.org/2314903003/diff/100001/chrome/app/chromium_st...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/2314903003/diff/100001/chrome/app/chromium_st...
chrome/app/chromium_strings.grd:560: desc="Message shown to the user on
chrome://downloads page to explain that this download is blocked because it is a
malware.">
On 2016/09/13 06:35:49, grt (UTC plus 2) wrote:
> nit: "it is malware"

fixed. Thanks for catching this.

https://codereview.chromium.org/2314903003/diff/100001/chrome/app/chromium_st...
chrome/app/chromium_strings.grd:564: desc="Message shown to the user on
chrome://downloads page to explain that this download is blocked because it is
an unwanted sofware.">
On 2016/09/13 06:35:49, grt (UTC plus 2) wrote:
> nit: "it is unwanted software"

Done. fix applied to google_chrome_strings.grd too.

[commit-bot: I haz the power, 2016-09-13 18:48:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 18:48:55]

Dry run: This issue passed the CQ dry run.

[Jialiu Lin, 2016-09-13 19:37:11]

The CQ bit was checked by jialiul@chromium.org

[Jialiu Lin, 2016-09-13 19:37:12]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org,
asanka@chromium.org, msw@chromium.org, grt@chromium.org
Link to the patchset: https://codereview.chromium.org/2314903003/#ps120001
(title: "address final nits")

[commit-bot: I haz the power, 2016-09-13 19:37:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 19:43:36]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-13 19:47:04]

Description was changed from

==========
Improve download recovery flow:

(1) refine strings in download recovery dialog
(2) remove all message leads, and keep title and message body to simply
    previously lengthy text in download recovery dialog
(3) refine description strings that used to explain the reason why download
    is blocked in chrome://downloads (text in orange)
(4) If download danger type is DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE, when user
    try to recover a blocked download, directly proceed instead of showing
    download danger prompt.
go/fix_download_recovery  for more detail

BUG=640673
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Improve download recovery flow:

(1) refine strings in download recovery dialog
(2) remove all message leads, and keep title and message body to simply
    previously lengthy text in download recovery dialog
(3) refine description strings that used to explain the reason why download
    is blocked in chrome://downloads (text in orange)
(4) If download danger type is DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE, when user
    try to recover a blocked download, directly proceed instead of showing
    download danger prompt.
go/fix_download_recovery  for more detail

BUG=640673
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/f857966ed00a2e7703f98f901d28ae3677592341
Cr-Commit-Position: refs/heads/master@{#418340}
==========

[commit-bot: I haz the power, 2016-09-13 19:47:06]

Patchset 7 (id:??) landed as
https://crrev.com/f857966ed00a2e7703f98f901d28ae3677592341
Cr-Commit-Position: refs/heads/master@{#418340}