Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6137)

Unified Diff: chrome/browser/download/download_danger_prompt.h

Issue 2314903003: Improve download recovery flow: (Closed)
Patch Set: address final nits Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/google_chrome_strings.grd ('k') | chrome/browser/resources/md_downloads/crisper.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_danger_prompt.h
diff --git a/chrome/browser/download/download_danger_prompt.h b/chrome/browser/download/download_danger_prompt.h
index de31c051fd0d4929a21cfca50d84904b3f542f00..6fa42a7e1330667c520dd4116509b482a3047912 100644
--- a/chrome/browser/download/download_danger_prompt.h
+++ b/chrome/browser/download/download_danger_prompt.h
@@ -52,7 +52,6 @@ class DownloadDangerPrompt {
// respective button click handler.
virtual void InvokeActionForTesting(Action action) = 0;
- protected:
// Sends download recovery report to safe browsing backend.
// Since it only records download url (DownloadItem::GetURL()), user's
// action (click through or not) and its download danger type, it isn't gated
@@ -64,6 +63,7 @@ class DownloadDangerPrompt {
bool did_proceed,
const content::DownloadItem& download);
+ protected:
// Records UMA stats for a download danger prompt event.
static void RecordDownloadDangerPrompt(bool did_proceed,
const content::DownloadItem& download);
« no previous file with comments | « chrome/app/google_chrome_strings.grd ('k') | chrome/browser/resources/md_downloads/crisper.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698