Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6555)

Unified Diff: chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc

Issue 2314903003: Improve download recovery flow: (Closed)
Patch Set: address final nits Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc
diff --git a/chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc b/chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc
index 1f075eec8fe39f8f2e2d9fc0708b9d97001e424f..f37dfe5883fe309a37a2c0e1d1757e3e3bee7aba 100644
--- a/chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc
+++ b/chrome/browser/ui/cocoa/download/download_danger_prompt_impl.cc
@@ -129,10 +129,10 @@ base::string16 DownloadDangerPromptImpl::GetTitle() {
case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_URL:
case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_CONTENT:
case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_HOST:
- case content::DOWNLOAD_DANGER_TYPE_POTENTIALLY_UNWANTED: {
- return l10n_util::GetStringUTF16(
- IDS_RESTORE_KEEP_DANGEROUS_DOWNLOAD_TITLE);
- }
+ case content::DOWNLOAD_DANGER_TYPE_POTENTIALLY_UNWANTED:
+ return l10n_util::GetStringUTF16(IDS_KEEP_DANGEROUS_DOWNLOAD_TITLE);
+ case content::DOWNLOAD_DANGER_TYPE_UNCOMMON_CONTENT:
+ return l10n_util::GetStringUTF16(IDS_KEEP_UNCOMMON_DOWNLOAD_TITLE);
default: {
return l10n_util::GetStringUTF16(
IDS_CONFIRM_KEEP_DANGEROUS_DOWNLOAD_TITLE);
@@ -176,11 +176,10 @@ base::string16 DownloadDangerPromptImpl::GetDialogMessage() {
switch (download_->GetDangerType()) {
case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_URL:
case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_CONTENT:
- case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_HOST: {
+ case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_HOST:
+ case content::DOWNLOAD_DANGER_TYPE_POTENTIALLY_UNWANTED:
+ case content::DOWNLOAD_DANGER_TYPE_UNCOMMON_CONTENT: {
return l10n_util::GetStringUTF16(
- IDS_PROMPT_CONFIRM_KEEP_MALICIOUS_DOWNLOAD_LEAD) +
- base::ASCIIToUTF16("\n\n") +
- l10n_util::GetStringUTF16(
IDS_PROMPT_CONFIRM_KEEP_MALICIOUS_DOWNLOAD_BODY);
}
default: {
@@ -196,31 +195,11 @@ base::string16 DownloadDangerPromptImpl::GetDialogMessage() {
base::string16 DownloadDangerPromptImpl::GetAcceptButtonTitle() {
if (show_context_)
return l10n_util::GetStringUTF16(IDS_CONFIRM_DOWNLOAD);
- switch (download_->GetDangerType()) {
- case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_URL:
- case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_CONTENT:
- case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_HOST:
- case content::DOWNLOAD_DANGER_TYPE_POTENTIALLY_UNWANTED: {
- return l10n_util::GetStringUTF16(IDS_CONFIRM_DOWNLOAD_AGAIN_MALICIOUS);
- }
- default:
- return l10n_util::GetStringUTF16(IDS_CONFIRM_DOWNLOAD_AGAIN);
- }
+ return l10n_util::GetStringUTF16(IDS_CONFIRM_DOWNLOAD_AGAIN);
}
base::string16 DownloadDangerPromptImpl::GetCancelButtonTitle() {
- if (show_context_)
- return l10n_util::GetStringUTF16(IDS_CANCEL);
- switch (download_->GetDangerType()) {
- case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_URL:
- case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_CONTENT:
- case content::DOWNLOAD_DANGER_TYPE_DANGEROUS_HOST:
- case content::DOWNLOAD_DANGER_TYPE_POTENTIALLY_UNWANTED: {
- return l10n_util::GetStringUTF16(IDS_CONFIRM_CANCEL_AGAIN_MALICIOUS);
- }
- default:
- return l10n_util::GetStringUTF16(IDS_CANCEL);
- }
+ return l10n_util::GetStringUTF16(IDS_CANCEL);
}
void DownloadDangerPromptImpl::OnAccepted() {
« no previous file with comments | « chrome/browser/resources/md_downloads/item.js ('k') | chrome/browser/ui/views/download/download_danger_prompt_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698