Revert of Revamp filter primitive region calculations for Filter Effects (patchset #4 id:60001 of https://codereview.chromium.org/2303703002/ )
Reason for revert:
Introduced failure on WebKit Mac10.11 (retina) bot in effect-reference-hw.html.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29
Original issue's description:
> Revamp filter primitive region calculations for Filter Effects
>
> This moves the filter primitive region calculation to
> SVGFilterPrimitiveStandardAttributes::setStandardAttributes, folding in
> FilterEffect::applyEffectBoundaries and getting rid of
> FilterEffect::m_effectBoundaries and related flags.
> What's left of FilterEffect::determineFilterPrimitiveSubregion() is
> renamed to determineMaximumEffectRect(), and callsites updated.
>
> BUG=642035
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/59aa6aab66c0a3c12644d44c686c02d484814da6
> Cr-Commit-Position: refs/heads/master@{#416472}
TBR=pdr@chromium.org,senorblanco@chromium.org,fs@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642035
Committed: https://crrev.com/89aabf1d2bfaf01c45bbb0af2f1b825ac22c29e1
Cr-Commit-Position: refs/heads/master@{#416498}
Description was changed from ========== Revert of Revamp filter primitive region calculations for Filter Effects ...
4 years, 3 months ago
(2016-09-05 05:35:25 UTC)
#4
Message was sent while issue was closed.
Description was changed from
==========
Revert of Revamp filter primitive region calculations for Filter Effects
(patchset #4 id:60001 of https://codereview.chromium.org/2303703002/ )
Reason for revert:
Introduced failure on WebKit Mac10.11 (retina) bot in effect-reference-hw.html.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28...
Original issue's description:
> Revamp filter primitive region calculations for Filter Effects
>
> This moves the filter primitive region calculation to
> SVGFilterPrimitiveStandardAttributes::setStandardAttributes, folding in
> FilterEffect::applyEffectBoundaries and getting rid of
> FilterEffect::m_effectBoundaries and related flags.
> What's left of FilterEffect::determineFilterPrimitiveSubregion() is
> renamed to determineMaximumEffectRect(), and callsites updated.
>
> BUG=642035
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/59aa6aab66c0a3c12644d44c686c02d484814da6
> Cr-Commit-Position: refs/heads/master@{#416472}
TBR=pdr@chromium.org,senorblanco@chromium.org,fs@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642035
==========
to
==========
Revert of Revamp filter primitive region calculations for Filter Effects
(patchset #4 id:60001 of https://codereview.chromium.org/2303703002/ )
Reason for revert:
Introduced failure on WebKit Mac10.11 (retina) bot in effect-reference-hw.html.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28...
Original issue's description:
> Revamp filter primitive region calculations for Filter Effects
>
> This moves the filter primitive region calculation to
> SVGFilterPrimitiveStandardAttributes::setStandardAttributes, folding in
> FilterEffect::applyEffectBoundaries and getting rid of
> FilterEffect::m_effectBoundaries and related flags.
> What's left of FilterEffect::determineFilterPrimitiveSubregion() is
> renamed to determineMaximumEffectRect(), and callsites updated.
>
> BUG=642035
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/59aa6aab66c0a3c12644d44c686c02d484814da6
> Cr-Commit-Position: refs/heads/master@{#416472}
TBR=pdr@chromium.org,senorblanco@chromium.org,fs@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642035
==========
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago
(2016-09-05 05:35:26 UTC)
#5
Message was sent while issue was closed.
Committed patchset #1 (id:1)
commit-bot: I haz the power
Description was changed from ========== Revert of Revamp filter primitive region calculations for Filter Effects ...
4 years, 3 months ago
(2016-09-05 05:36:50 UTC)
#6
Message was sent while issue was closed.
Description was changed from
==========
Revert of Revamp filter primitive region calculations for Filter Effects
(patchset #4 id:60001 of https://codereview.chromium.org/2303703002/ )
Reason for revert:
Introduced failure on WebKit Mac10.11 (retina) bot in effect-reference-hw.html.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28...
Original issue's description:
> Revamp filter primitive region calculations for Filter Effects
>
> This moves the filter primitive region calculation to
> SVGFilterPrimitiveStandardAttributes::setStandardAttributes, folding in
> FilterEffect::applyEffectBoundaries and getting rid of
> FilterEffect::m_effectBoundaries and related flags.
> What's left of FilterEffect::determineFilterPrimitiveSubregion() is
> renamed to determineMaximumEffectRect(), and callsites updated.
>
> BUG=642035
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/59aa6aab66c0a3c12644d44c686c02d484814da6
> Cr-Commit-Position: refs/heads/master@{#416472}
TBR=pdr@chromium.org,senorblanco@chromium.org,fs@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642035
==========
to
==========
Revert of Revamp filter primitive region calculations for Filter Effects
(patchset #4 id:60001 of https://codereview.chromium.org/2303703002/ )
Reason for revert:
Introduced failure on WebKit Mac10.11 (retina) bot in effect-reference-hw.html.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28...
Original issue's description:
> Revamp filter primitive region calculations for Filter Effects
>
> This moves the filter primitive region calculation to
> SVGFilterPrimitiveStandardAttributes::setStandardAttributes, folding in
> FilterEffect::applyEffectBoundaries and getting rid of
> FilterEffect::m_effectBoundaries and related flags.
> What's left of FilterEffect::determineFilterPrimitiveSubregion() is
> renamed to determineMaximumEffectRect(), and callsites updated.
>
> BUG=642035
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/59aa6aab66c0a3c12644d44c686c02d484814da6
> Cr-Commit-Position: refs/heads/master@{#416472}
TBR=pdr@chromium.org,senorblanco@chromium.org,fs@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642035
Committed: https://crrev.com/89aabf1d2bfaf01c45bbb0af2f1b825ac22c29e1
Cr-Commit-Position: refs/heads/master@{#416498}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/89aabf1d2bfaf01c45bbb0af2f1b825ac22c29e1 Cr-Commit-Position: refs/heads/master@{#416498}
4 years, 3 months ago
(2016-09-05 05:36:51 UTC)
#7
Issue 2313583002: Revert of Revamp filter primitive region calculations for Filter Effects
(Closed)
Created 4 years, 3 months ago by Matt Giuca
Modified 4 years, 3 months ago
Reviewers: pdr., Stephen White, fs
Base URL:
Comments: 0