Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2313583002: Revert of Revamp filter primitive region calculations for Filter Effects (Closed)

Created:
4 years, 3 months ago by Matt Giuca
Modified:
4 years, 3 months ago
Reviewers:
pdr., Stephen White, fs
CC:
ajuma+watch_chromium.org, ajuma+watch-canvas_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), gyuyoung2, jbroman, Justin Novosad, kouhei+svg_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revamp filter primitive region calculations for Filter Effects (patchset #4 id:60001 of https://codereview.chromium.org/2303703002/ ) Reason for revert: Introduced failure on WebKit Mac10.11 (retina) bot in effect-reference-hw.html. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29 Original issue's description: > Revamp filter primitive region calculations for Filter Effects > > This moves the filter primitive region calculation to > SVGFilterPrimitiveStandardAttributes::setStandardAttributes, folding in > FilterEffect::applyEffectBoundaries and getting rid of > FilterEffect::m_effectBoundaries and related flags. > What's left of FilterEffect::determineFilterPrimitiveSubregion() is > renamed to determineMaximumEffectRect(), and callsites updated. > > BUG=642035 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Committed: https://crrev.com/59aa6aab66c0a3c12644d44c686c02d484814da6 > Cr-Commit-Position: refs/heads/master@{#416472} TBR=pdr@chromium.org,senorblanco@chromium.org,fs@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=642035 Committed: https://crrev.com/89aabf1d2bfaf01c45bbb0af2f1b825ac22c29e1 Cr-Commit-Position: refs/heads/master@{#416498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -108 lines) Patch
M third_party/WebKit/LayoutTests/css3/filters/feoffset-region-zoom-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-all-on-background-hw-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-colorspace-hw-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-hw-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-ordering-hw-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/css3/filters/effect-reference-zoom-hw-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/css3/filters/effect-reference-hw-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-all-on-background-hw-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-colorspace-hw-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-hw-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-ordering-hw-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-zoom-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css3/filters/effect-reference-zoom-hw-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-all-on-background-hw-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-colorspace-hw-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-hw-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-ordering-hw-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-zoom-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/effect-reference-zoom-hw-expected.png View Binary file 0 comments Download
M third_party/WebKit/Source/core/paint/FilterPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp View 1 chunk +5 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp View 1 chunk +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FETile.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FETurbulence.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h View 5 chunks +31 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp View 3 chunks +55 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Matt Giuca
Created Revert of Revamp filter primitive region calculations for Filter Effects
4 years, 3 months ago (2016-09-05 05:33:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313583002/1
4 years, 3 months ago (2016-09-05 05:34:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 05:35:26 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 05:36:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89aabf1d2bfaf01c45bbb0af2f1b825ac22c29e1
Cr-Commit-Position: refs/heads/master@{#416498}

Powered by Google App Engine
This is Rietveld 408576698