third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.h - Issue 2313583002: Revert of Revamp filter primitive region calculations for Filter Effects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.h

Issue 2313583002: Revert of Revamp filter primitive region calculations for Filter Effects (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp ('k') | third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.h

diff --git a/third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.h b/third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.h

index 3f63cc984bd069260ded5881fe257c07fb953b34..12f64fba52f29a562e1e998db485510b647e7e7f 100644

--- a/third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.h

+++ b/third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.h

@@ -24,8 +24,9 @@

#include "core/svg/SVGAnimatedLength.h"

#include "core/svg/SVGAnimatedString.h"

#include "core/svg/SVGElement.h"

-#include "core/svg/SVGUnitTypes.h"

#include "platform/heap/Handle.h"

+#include "wtf/PassRefPtr.h"

+#include "wtf/RefPtr.h"

namespace blink {

@@ -38,8 +39,7 @@

// instantiated, and b) we don't generate corresponding V8T.h or V8T.cpp.

// The subclasses must write DEFINE_WRAPPERTYPEINFO().

public:

- void setStandardAttributes(

- FilterEffect*, SVGUnitTypes::SVGUnitType, const FloatRect& referenceBox) const;

+ void setStandardAttributes(FilterEffect*) const;

virtual FilterEffect* build(SVGFilterBuilder*, Filter*) = 0;

// Returns true, if the new value is different from the old one.