third_party/WebKit/Source/platform/graphics/filters/FETile.cpp - Issue 2313583002: Revert of Revamp filter primitive region calculations for Filter Effects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FETile.cpp

Issue 2313583002: Revert of Revamp filter primitive region calculations for Filter Effects (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/filters/FETile.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FETile.cpp b/third_party/WebKit/Source/platform/graphics/filters/FETile.cpp

index b777eb13ea2dd0d977600bf0d07bcf1977c76771..8677ed991cbdee191da940562afbad4b0941fbc9 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FETile.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FETile.cpp

@@ -46,12 +46,8 @@

sk_sp<SkImageFilter> FETile::createImageFilter()

{

sk_sp<SkImageFilter> input(SkiaImageFilterBuilder::build(inputEffect(0), operatingColorSpace()));

- FloatRect srcRect;

- if (inputEffect(0)->getFilterEffectType() == FilterEffectTypeSourceInput)

- srcRect = getFilter()->filterRegion();

- else

- srcRect = inputEffect(0)->filterPrimitiveSubregion();

- FloatRect dstRect = filterPrimitiveSubregion();

+ FloatRect srcRect = inputEffect(0)->filterPrimitiveSubregion();

+ FloatRect dstRect = applyEffectBoundaries(getFilter()->filterRegion());

return SkTileImageFilter::Make(srcRect, dstRect, std::move(input));

}