Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2311533002: [Extensions UI] Remove override of toolbar redesign in many tests (Closed)

Created:
4 years, 3 months ago by Devlin
Modified:
4 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions UI] Remove override of toolbar redesign in many tests Some extensions tests had the toolbar redesign disabled by a custom override. Some of these are testing legacy behavior, but many were just never changed over. Update many to remove the custom override, enabling the redesign. In order to stay targeted, this CL doesn't update behavior expectations for any tests. That will be done in a followup. BUG=None Committed: https://crrev.com/6c7eccf9c5be9b32c3c194ce95e2b28bb3a8ad38 Cr-Commit-Position: refs/heads/master@{#417068}

Patch Set 1 : mac #

Messages

Total messages: 27 (20 generated)
Devlin
Hey Finnur, mind taking a quick look?
4 years, 3 months ago (2016-09-07 14:10:27 UTC) #17
Finnur
LGTM
4 years, 3 months ago (2016-09-07 16:29:53 UTC) #18
Devlin
+Avi for small cocoa change
4 years, 3 months ago (2016-09-07 17:56:30 UTC) #20
Avi (use Gerrit)
cocoa lgtm
4 years, 3 months ago (2016-09-07 20:09:48 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2311533002/40001
4 years, 3 months ago (2016-09-07 20:13:01 UTC) #23
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 3 months ago (2016-09-07 21:58:48 UTC) #25
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 22:02:45 UTC) #27
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c7eccf9c5be9b32c3c194ce95e2b28bb3a8ad38
Cr-Commit-Position: refs/heads/master@{#417068}

Powered by Google App Engine
This is Rietveld 408576698