Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm

Issue 2311533002: [Extensions UI] Remove override of toolbar redesign in many tests (Closed)
Patch Set: mac Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "chrome/browser/ui/browser_window.h" 6 #include "chrome/browser/ui/browser_window.h"
7 #import "chrome/browser/ui/cocoa/browser_window_controller.h" 7 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
8 #import "chrome/browser/ui/cocoa/extensions/browser_action_button.h" 8 #import "chrome/browser/ui/cocoa/extensions/browser_action_button.h"
9 #import "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h" 9 #import "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h"
10 #import "chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h" 10 #import "chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h"
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 void CheckBubbleNative(Browser* browser, AnchorPosition anchor) override; 98 void CheckBubbleNative(Browser* browser, AnchorPosition anchor) override;
99 void CloseBubbleNative(Browser* browser) override; 99 void CloseBubbleNative(Browser* browser) override;
100 void CheckBubbleIsNotPresentNative(Browser* browser) override; 100 void CheckBubbleIsNotPresentNative(Browser* browser) override;
101 void ClickLearnMoreButton(Browser* browser) override; 101 void ClickLearnMoreButton(Browser* browser) override;
102 void ClickActionButton(Browser* browser) override; 102 void ClickActionButton(Browser* browser) override;
103 void ClickDismissButton(Browser* browser) override; 103 void ClickDismissButton(Browser* browser) override;
104 104
105 DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleBrowserTestMac); 105 DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleBrowserTestMac);
106 }; 106 };
107 107
108 class ExtensionMessageBubbleBrowserTestRedesignMac 108 class ExtensionMessageBubbleBrowserTestLegacyMac
109 : public ExtensionMessageBubbleBrowserTestMac { 109 : public ExtensionMessageBubbleBrowserTestMac {
110 protected: 110 protected:
111 void SetUpCommandLine(base::CommandLine* command_line) override { 111 void SetUpCommandLine(base::CommandLine* command_line) override {
112 ExtensionMessageBubbleBrowserTestMac::SetUpCommandLine(command_line); 112 ExtensionMessageBubbleBrowserTestMac::SetUpCommandLine(command_line);
113 override_redesign_.reset(); 113 override_redesign_.reset();
114 override_redesign_.reset(new extensions::FeatureSwitch::ScopedOverride(
115 extensions::FeatureSwitch::extension_action_redesign(), false));
114 } 116 }
115 }; 117 };
116 118
117 void ExtensionMessageBubbleBrowserTestMac::SetUpCommandLine( 119 void ExtensionMessageBubbleBrowserTestMac::SetUpCommandLine(
118 base::CommandLine* command_line) { 120 base::CommandLine* command_line) {
119 ExtensionMessageBubbleBrowserTest::SetUpCommandLine(command_line); 121 ExtensionMessageBubbleBrowserTest::SetUpCommandLine(command_line);
120 [ToolbarActionsBarBubbleMac setAnimationEnabledForTesting:NO]; 122 [ToolbarActionsBarBubbleMac setAnimationEnabledForTesting:NO];
121 } 123 }
122 124
123 void ExtensionMessageBubbleBrowserTestMac::CheckBubbleNative( 125 void ExtensionMessageBubbleBrowserTestMac::CheckBubbleNative(
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 Browser* browser) { 173 Browser* browser) {
172 ToolbarActionsBarBubbleMac* bubble = GetBubbleForBrowser(browser); 174 ToolbarActionsBarBubbleMac* bubble = GetBubbleForBrowser(browser);
173 ClickInView([bubble dismissButton]); 175 ClickInView([bubble dismissButton]);
174 } 176 }
175 177
176 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac, 178 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
177 ExtensionBubbleAnchoredToExtensionAction) { 179 ExtensionBubbleAnchoredToExtensionAction) {
178 TestBubbleAnchoredToExtensionAction(); 180 TestBubbleAnchoredToExtensionAction();
179 } 181 }
180 182
181 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac, 183 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestLegacyMac,
182 ExtensionBubbleAnchoredToAppMenu) { 184 ExtensionBubbleAnchoredToAppMenu) {
183 TestBubbleAnchoredToAppMenu(); 185 TestBubbleAnchoredToAppMenu();
184 } 186 }
185 187
186 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac, 188 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestLegacyMac,
187 ExtensionBubbleAnchoredToAppMenuWithOtherAction) { 189 ExtensionBubbleAnchoredToAppMenuWithOtherAction) {
188 TestBubbleAnchoredToAppMenuWithOtherAction(); 190 TestBubbleAnchoredToAppMenuWithOtherAction();
189 } 191 }
190 192
191 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac, 193 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
192 PRE_ExtensionBubbleShowsOnStartup) { 194 PRE_ExtensionBubbleShowsOnStartup) {
193 PreBubbleShowsOnStartup(); 195 PreBubbleShowsOnStartup();
194 } 196 }
195 197
196 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac, 198 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
(...skipping 24 matching lines...) Expand all
221 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac, 223 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
222 TestClickingActionButton) { 224 TestClickingActionButton) {
223 TestClickingActionButton(); 225 TestClickingActionButton();
224 } 226 }
225 227
226 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac, 228 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
227 TestClickingDismissButton) { 229 TestClickingDismissButton) {
228 TestClickingDismissButton(); 230 TestClickingDismissButton();
229 } 231 }
230 232
231 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestRedesignMac, 233 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
232 TestControlledHomeMessageBubble) { 234 TestControlledHomeMessageBubble) {
233 TestControlledHomeBubbleShown(); 235 TestControlledHomeBubbleShown();
234 } 236 }
235 237
236 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestRedesignMac, 238 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
237 TestControlledSearchMessageBubble) { 239 TestControlledSearchMessageBubble) {
238 TestControlledSearchBubbleShown(); 240 TestControlledSearchBubbleShown();
239 } 241 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698