Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm

Issue 2311533002: [Extensions UI] Remove override of toolbar redesign in many tests (Closed)
Patch Set: mac Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm b/chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm
index b91f7d5a0eac82e253fb3eb72fe3b743301cf945..d4bc50ca3279f999fb1b1dd4e27fcea51c9062b2 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm
@@ -105,12 +105,14 @@ class ExtensionMessageBubbleBrowserTestMac
DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleBrowserTestMac);
};
-class ExtensionMessageBubbleBrowserTestRedesignMac
+class ExtensionMessageBubbleBrowserTestLegacyMac
: public ExtensionMessageBubbleBrowserTestMac {
protected:
void SetUpCommandLine(base::CommandLine* command_line) override {
ExtensionMessageBubbleBrowserTestMac::SetUpCommandLine(command_line);
override_redesign_.reset();
+ override_redesign_.reset(new extensions::FeatureSwitch::ScopedOverride(
+ extensions::FeatureSwitch::extension_action_redesign(), false));
}
};
@@ -178,12 +180,12 @@ IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
TestBubbleAnchoredToExtensionAction();
}
-IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
+IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestLegacyMac,
ExtensionBubbleAnchoredToAppMenu) {
TestBubbleAnchoredToAppMenu();
}
-IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
+IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestLegacyMac,
ExtensionBubbleAnchoredToAppMenuWithOtherAction) {
TestBubbleAnchoredToAppMenuWithOtherAction();
}
@@ -228,12 +230,12 @@ IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
TestClickingDismissButton();
}
-IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestRedesignMac,
+IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
TestControlledHomeMessageBubble) {
TestControlledHomeBubbleShown();
}
-IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestRedesignMac,
+IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
TestControlledSearchMessageBubble) {
TestControlledSearchBubbleShown();
}
« no previous file with comments | « no previous file | chrome/browser/ui/extensions/extension_action_view_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698