Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view_browsertest.cc

Issue 2311533002: [Extensions UI] Remove override of toolbar redesign in many tests (Closed)
Patch Set: mac Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "chrome/browser/ui/extensions/extension_message_bubble_browsertest.h" 6 #include "chrome/browser/ui/extensions/extension_message_bubble_browsertest.h"
7 #include "chrome/browser/ui/toolbar/toolbar_actions_bar.h" 7 #include "chrome/browser/ui/toolbar/toolbar_actions_bar.h"
8 #include "chrome/browser/ui/views/frame/browser_view.h" 8 #include "chrome/browser/ui/views/frame/browser_view.h"
9 #include "chrome/browser/ui/views/toolbar/app_menu_button.h" 9 #include "chrome/browser/ui/views/toolbar/app_menu_button.h"
10 #include "chrome/browser/ui/views/toolbar/browser_actions_container.h" 10 #include "chrome/browser/ui/views/toolbar/browser_actions_container.h"
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 void CheckBubbleNative(Browser* browser, AnchorPosition anchor) override; 65 void CheckBubbleNative(Browser* browser, AnchorPosition anchor) override;
66 void CloseBubbleNative(Browser* browser) override; 66 void CloseBubbleNative(Browser* browser) override;
67 void CheckBubbleIsNotPresentNative(Browser* browser) override; 67 void CheckBubbleIsNotPresentNative(Browser* browser) override;
68 void ClickLearnMoreButton(Browser* browser) override; 68 void ClickLearnMoreButton(Browser* browser) override;
69 void ClickActionButton(Browser* browser) override; 69 void ClickActionButton(Browser* browser) override;
70 void ClickDismissButton(Browser* browser) override; 70 void ClickDismissButton(Browser* browser) override;
71 71
72 DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleViewBrowserTest); 72 DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleViewBrowserTest);
73 }; 73 };
74 74
75 class ExtensionMessageBubbleViewBrowserTestRedesign 75 class ExtensionMessageBubbleViewBrowserTestLegacy
76 : public ExtensionMessageBubbleViewBrowserTest { 76 : public ExtensionMessageBubbleViewBrowserTest {
77 protected: 77 protected:
78 void SetUpCommandLine(base::CommandLine* command_line) override { 78 void SetUpCommandLine(base::CommandLine* command_line) override {
79 ExtensionMessageBubbleViewBrowserTest::SetUpCommandLine(command_line); 79 ExtensionMessageBubbleViewBrowserTest::SetUpCommandLine(command_line);
80 override_redesign_.reset(); 80 override_redesign_.reset();
81 override_redesign_.reset(new extensions::FeatureSwitch::ScopedOverride(
82 extensions::FeatureSwitch::extension_action_redesign(), false));
81 } 83 }
82 }; 84 };
83 85
84 void ExtensionMessageBubbleViewBrowserTest::CheckBubbleNative( 86 void ExtensionMessageBubbleViewBrowserTest::CheckBubbleNative(
85 Browser* browser, 87 Browser* browser,
86 AnchorPosition anchor) { 88 AnchorPosition anchor) {
87 ToolbarView* toolbar_view = GetToolbarViewForBrowser(browser); 89 ToolbarView* toolbar_view = GetToolbarViewForBrowser(browser);
88 BrowserActionsContainer* container = toolbar_view->browser_actions(); 90 BrowserActionsContainer* container = toolbar_view->browser_actions();
89 views::BubbleDialogDelegateView* bubble = container->active_bubble(); 91 views::BubbleDialogDelegateView* bubble = container->active_bubble();
90 views::View* anchor_view = nullptr; 92 views::View* anchor_view = nullptr;
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 Browser* browser) { 136 Browser* browser) {
135 ToolbarActionsBarBubbleViews* bubble = GetBubbleForBrowser(browser); 137 ToolbarActionsBarBubbleViews* bubble = GetBubbleForBrowser(browser);
136 bubble->GetDialogClientView()->CancelWindow(); 138 bubble->GetDialogClientView()->CancelWindow();
137 } 139 }
138 140
139 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest, 141 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
140 ExtensionBubbleAnchoredToExtensionAction) { 142 ExtensionBubbleAnchoredToExtensionAction) {
141 TestBubbleAnchoredToExtensionAction(); 143 TestBubbleAnchoredToExtensionAction();
142 } 144 }
143 145
144 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest, 146 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTestLegacy,
145 ExtensionBubbleAnchoredToAppMenu) { 147 ExtensionBubbleAnchoredToAppMenu) {
146 TestBubbleAnchoredToAppMenu(); 148 TestBubbleAnchoredToAppMenu();
147 } 149 }
148 150
149 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest, 151 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTestLegacy,
150 ExtensionBubbleAnchoredToAppMenuWithOtherAction) { 152 ExtensionBubbleAnchoredToAppMenuWithOtherAction) {
151 TestBubbleAnchoredToAppMenuWithOtherAction(); 153 TestBubbleAnchoredToAppMenuWithOtherAction();
152 } 154 }
153 155
154 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest, 156 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
155 PRE_ExtensionBubbleShowsOnStartup) { 157 PRE_ExtensionBubbleShowsOnStartup) {
156 PreBubbleShowsOnStartup(); 158 PreBubbleShowsOnStartup();
157 } 159 }
158 160
159 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest, 161 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
160 ExtensionBubbleShowsOnStartup) { 162 ExtensionBubbleShowsOnStartup) {
161 TestBubbleShowsOnStartup(); 163 TestBubbleShowsOnStartup();
162 } 164 }
163 165
164 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest, 166 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
165 TestUninstallDangerousExtension) { 167 TestUninstallDangerousExtension) {
166 TestUninstallDangerousExtension(); 168 TestUninstallDangerousExtension();
167 } 169 }
168 170
169 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest, 171 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
170 TestDevModeBubbleIsntShownTwice) { 172 TestDevModeBubbleIsntShownTwice) {
171 TestDevModeBubbleIsntShownTwice(); 173 TestDevModeBubbleIsntShownTwice();
172 } 174 }
173 175
174 // Tests for the extension bubble and settings overrides. These bubbles are 176 // Tests for the extension bubble and settings overrides. These bubbles are
175 // currently only shown on Windows. 177 // currently only shown on Windows.
176 #if defined(OS_WIN) 178 #if defined(OS_WIN)
177 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTestRedesign, 179 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
178 TestControlledNewTabPageMessageBubble) { 180 TestControlledNewTabPageMessageBubble) {
179 TestControlledNewTabPageBubbleShown(); 181 TestControlledNewTabPageBubbleShown();
180 } 182 }
181 183
182 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTestRedesign, 184 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
183 TestControlledHomeMessageBubble) { 185 TestControlledHomeMessageBubble) {
184 TestControlledHomeBubbleShown(); 186 TestControlledHomeBubbleShown();
185 } 187 }
186 188
187 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTestRedesign, 189 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
188 TestControlledSearchMessageBubble) { 190 TestControlledSearchMessageBubble) {
189 TestControlledSearchBubbleShown(); 191 TestControlledSearchBubbleShown();
190 } 192 }
191 #endif // defined(OS_WIN) 193 #endif // defined(OS_WIN)
192 194
193 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest, 195 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
194 TestBubbleWithMultipleWindows) { 196 TestBubbleWithMultipleWindows) {
195 TestBubbleWithMultipleWindows(); 197 TestBubbleWithMultipleWindows();
196 } 198 }
197 199
198 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest, 200 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
199 TestClickingLearnMoreButton) { 201 TestClickingLearnMoreButton) {
200 TestClickingLearnMoreButton(); 202 TestClickingLearnMoreButton();
201 } 203 }
202 204
203 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest, 205 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
204 TestClickingActionButton) { 206 TestClickingActionButton) {
205 TestClickingActionButton(); 207 TestClickingActionButton();
206 } 208 }
207 209
208 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest, 210 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleViewBrowserTest,
209 TestClickingDismissButton) { 211 TestClickingDismissButton) {
210 TestClickingDismissButton(); 212 TestClickingDismissButton();
211 } 213 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698