Remove unneeded split_count assignments

Remove unneeded split_count assignments

Refactoring of WebKit gn files has made splitting libraries less
necessary. This broke generating of build files. This change
removes the unneeded assignments.

The error, in the generate_build_files step, was:

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------
GN gen failed: 1

It first appeared in build 10455:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/10455/steps/generate_build_files/logs/stdio

Suspect is crrev.com/2299143005

TBR=brettw@chromium.org

Committed: https://crrev.com/f7d8febdf0166e2193b5e34e81b6b9dfb9ffd7c4
Cr-Commit-Position: refs/heads/master@{#416441}

[brucedawson, 2016-09-02 23:55:01]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[brucedawson, 2016-09-02 23:55:18]

The CQ bit was unchecked by brucedawson@chromium.org

[brucedawson, 2016-09-03 00:06:57]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-03 00:07:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-09-03 00:10:41]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-03 00:11:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-09-03 00:11:56]

The CQ bit was unchecked by brucedawson@chromium.org

[brucedawson, 2016-09-03 00:12:04]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-03 00:12:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 00:14:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-03 00:15:02]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brucedawson, 2016-09-03 00:18:08]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-03 00:18:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 00:22:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-03 00:22:15]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brucedawson, 2016-09-03 00:22:35]

Description was changed from

==========
Remove unneeded split_count assignments

Refactoring of WebKit gn files has made splitting libraries less
necessary. This broke generating of build files. This change
removes the unneeded assignments.
==========

to

==========
Remove unneeded split_count assignments

Refactoring of WebKit gn files has made splitting libraries less
necessary. This broke generating of build files. This change
removes the unneeded assignments.

The error, in the generate_build_files step, was:

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no
effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be
included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------
GN gen failed: 1

It first appeared in build 10455:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...
==========

[brucedawson, 2016-09-03 00:22:36]

brucedawson@chromium.org changed reviewers:
+ brettw@chromium.org

[brucedawson, 2016-09-03 00:34:09]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-03 00:34:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2016-09-03 00:46:34]

Description was changed from

==========
Remove unneeded split_count assignments

Refactoring of WebKit gn files has made splitting libraries less
necessary. This broke generating of build files. This change
removes the unneeded assignments.

The error, in the generate_build_files step, was:

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no
effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be
included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------
GN gen failed: 1

It first appeared in build 10455:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...
==========

to

==========
Remove unneeded split_count assignments

Refactoring of WebKit gn files has made splitting libraries less
necessary. This broke generating of build files. This change
removes the unneeded assignments.

The error, in the generate_build_files step, was:

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no
effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be
included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------
GN gen failed: 1

It first appeared in build 10455:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

Suspect is crrev.com/2299143005
==========

[brucedawson, 2016-09-03 00:48:13]

I think https://codereview.chromium.org/2299143005 broke official builds. I
think this is the right fix.

If the try bots pass:
  If you see this:
    Feel free to land.
  Else:
    I might TBR it.
Else:
  Not again...

[commit-bot: I haz the power, 2016-09-03 03:10:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-03 03:10:16]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2016-09-03 03:42:21]

Description was changed from

==========
Remove unneeded split_count assignments

Refactoring of WebKit gn files has made splitting libraries less
necessary. This broke generating of build files. This change
removes the unneeded assignments.

The error, in the generate_build_files step, was:

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no
effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be
included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------
GN gen failed: 1

It first appeared in build 10455:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

Suspect is crrev.com/2299143005
==========

to

==========
Remove unneeded split_count assignments

Refactoring of WebKit gn files has made splitting libraries less
necessary. This broke generating of build files. This change
removes the unneeded assignments.

The error, in the generate_build_files step, was:

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no
effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be
included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------
GN gen failed: 1

It first appeared in build 10455:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

Suspect is crrev.com/2299143005

TBR=brettw@chromium.org
==========

[brucedawson, 2016-09-03 03:43:28]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-09-03 03:43:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 03:47:42]

Description was changed from

==========
Remove unneeded split_count assignments

Refactoring of WebKit gn files has made splitting libraries less
necessary. This broke generating of build files. This change
removes the unneeded assignments.

The error, in the generate_build_files step, was:

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no
effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be
included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------
GN gen failed: 1

It first appeared in build 10455:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

Suspect is crrev.com/2299143005

TBR=brettw@chromium.org
==========

to

==========
Remove unneeded split_count assignments

Refactoring of WebKit gn files has made splitting libraries less
necessary. This broke generating of build files. This change
removes the unneeded assignments.

The error, in the generate_build_files step, was:

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no
effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be
included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------
GN gen failed: 1

It first appeared in build 10455:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

Suspect is crrev.com/2299143005

TBR=brettw@chromium.org
==========

[commit-bot: I haz the power, 2016-09-03 03:47:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-03 03:49:41]

Description was changed from

==========
Remove unneeded split_count assignments

Refactoring of WebKit gn files has made splitting libraries less
necessary. This broke generating of build files. This change
removes the unneeded assignments.

The error, in the generate_build_files step, was:

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no
effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be
included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------
GN gen failed: 1

It first appeared in build 10455:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

Suspect is crrev.com/2299143005

TBR=brettw@chromium.org
==========

to

==========
Remove unneeded split_count assignments

Refactoring of WebKit gn files has made splitting libraries less
necessary. This broke generating of build files. This change
removes the unneeded assignments.

The error, in the generate_build_files step, was:

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no
effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be
included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------
GN gen failed: 1

It first appeared in build 10455:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...

Suspect is crrev.com/2299143005

TBR=brettw@chromium.org

Committed: https://crrev.com/f7d8febdf0166e2193b5e34e81b6b9dfb9ffd7c4
Cr-Commit-Position: refs/heads/master@{#416441}
==========

[commit-bot: I haz the power, 2016-09-03 03:49:42]

Patchset 4 (id:??) landed as
https://crrev.com/f7d8febdf0166e2193b5e34e81b6b9dfb9ffd7c4
Cr-Commit-Position: refs/heads/master@{#416441}

[Nico, 2016-09-03 04:04:20]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-09-03 04:04:21]

https://codereview.chromium.org/2311493002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/BUILD.gn (right):

https://codereview.chromium.org/2311493002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/BUILD.gn:178: split_count = 19
wasn't this before effectively:

  if (is_win && is_official_build) {
    split_count = 19
  } else {
    split_count = 1
  }

ie the default value 5 always got overwritten (which is also what the warning
pointed out)?

[Nico, 2016-09-03 04:09:09]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2303293004/ by thakis@chromium.org.

The reason for reverting is: Due to this landing after my revert of Brett's
change, it broke the world, e.g.
https://build.chromium.org/p/chromium/builders/Android/builds/61684 . Since I'm
not sure if the patch is quite right, I'll revert this too..

[brucedawson, 2016-09-03 04:15:50]

On 2016/09/03 04:09:09, Nico (away until Tuesday) wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/2303293004/ by mailto:thakis@chromium.org.
> 
> The reason for reverting is: Due to this landing after my revert of Brett's
> change, it broke the world, e.g.
> https://build.chromium.org/p/chromium/builders/Android/builds/61684 . Since
I'm
> not sure if the patch is quite right, I'll revert this too..

Thanks. Not sure why it broke the world after passing the try bots, but
reverting is clearly the right thing to do. Conflicts between our changes I
guess. C'est la vie.

[Nico, 2016-09-03 04:17:55]

On 2016/09/03 04:15:50, brucedawson wrote:
> On 2016/09/03 04:09:09, Nico (away until Tuesday) wrote:
> > A revert of this CL (patchset #4 id:60001) has been created in
> > https://codereview.chromium.org/2303293004/ by mailto:thakis@chromium.org.
> > 
> > The reason for reverting is: Due to this landing after my revert of Brett's
> > change, it broke the world, e.g.
> > https://build.chromium.org/p/chromium/builders/Android/builds/61684 . Since
> I'm
> > not sure if the patch is quite right, I'll revert this too..
> 
> Thanks. Not sure why it broke the world after passing the try bots

You kicked off try jobs 3h ago, I reverted Brett's change ~20 minutes ago. The
trybots always test against a slightly old checkout and hope that nothing badly
conflicting lands. Most of the time this works, but not always.