Remove unneeded split_count assignments

third_party/WebKit/Source/core/BUILD.gn

Index: third_party/WebKit/Source/core/BUILD.gn
diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn
index b6d7dcb7654cd2577d8f5ba5493204e3654380f3..d1d73cb597175ca0ca12ecac085fda7e943ff797 100644
--- a/third_party/WebKit/Source/core/BUILD.gn
+++ b/third_party/WebKit/Source/core/BUILD.gn
@@ -45,16 +45,6 @@ config("core_include_dirs") {
   }
 }
 
-if (!is_component_build) {
-  if (is_win && is_official_build) {
-    # Shard this target into parts to work around linker limitations
-    # on link time code generation builds.
-    split_count = 5
-  } else {
-    split_count = 1
-  }
-}
-
 source_set("generated") {
   deps = [
     ":core_generated",
@@ -180,11 +170,18 @@ component("core") {
 }
 
 target(core_link_large_target_type, "remaining") {
-  if (is_win && is_official_build &&
-      core_link_large_target_type == "split_static_library") {
+  if (core_link_large_target_type == "split_static_library") {
     # Shard this target into parts to work around linker limitations
     # on link time code generation builds.
-    split_count = 19
+    if (is_win) {
+      if (is_official_build) {
+        split_count = 19

[Nico, 2016/09/03 04:04:21]

wasn't this before effectively:

  if (is_win && is_official_build) {
    split_count = 19
  } else {
    split_count = 1
  }

ie the default value 5 always got overwritten (which is also what the warning
pointed out)?

+      } else {
+        split_count = 5
+      }
+    } else {
+      split_count = 1
+    }
   }
 
   # This is currently a mashup of "webcore_rendering" and "webcore_remaining"