Remove unneeded split_count assignments

third_party/WebKit/Source/core/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chromecast_build.gni")
 import("//build/config/ui.gni")
 import("//build/split_static_library.gni")
 import("//testing/libfuzzer/fuzzer_test.gni")
 import("//third_party/WebKit/Source/bindings/bindings.gni")
 import("//third_party/WebKit/Source/bindings/core/v8/generated.gni")
@@ skipping 27 matching lines @@
 config("core_include_dirs") {
   include_dirs = [
     "..",
     "$root_gen_dir/blink",
   ]
   if (is_android && use_openmax_dl_fft) {
     include_dirs += [ "//third_party/openmax_dl" ]
   }
 }
 
-if (!is_component_build) {
-  if (is_win && is_official_build) {
-    # Shard this target into parts to work around linker limitations
-    # on link time code generation builds.
-    split_count = 5
-  } else {
-    split_count = 1
-  }
-}
-
 source_set("generated") {
   deps = [
     ":core_generated",
     ":prerequisites",
     "//gin",
     "//skia",
     "//third_party/WebKit/Source/bindings/core/v8:bindings_core_v8_generated",
     "//third_party/WebKit/Source/core/inspector",
     "//third_party/iccjpeg",
     "//third_party/libpng",
@@ skipping 105 matching lines @@
     # Incremental linking doesn't work on this target in debug mode, even
     # with symbol_level=1.
     configs -= [ "//build/config/win:default_incremental_linking" ]
     configs += [ "//build/config/win:no_incremental_linking" ]
   }
 
   public_configs = [ ":core_include_dirs" ]
 }
 
 target(core_link_large_target_type, "remaining") {
-  if (is_win && is_official_build &&
-      core_link_large_target_type == "split_static_library") {
+  if (core_link_large_target_type == "split_static_library") {
     # Shard this target into parts to work around linker limitations
     # on link time code generation builds.
-    split_count = 19
+    if (is_win) {
+      if (is_official_build) {
+        split_count = 19

[Nico, 2016/09/03 04:04:21]

wasn't this before effectively:

  if (is_win && is_official_build) {
    split_count = 19
  } else {
    split_count = 1
  }

ie the default value 5 always got overwritten (which is also what the warning
pointed out)?

+      } else {
+        split_count = 5
+      }
+    } else {
+      split_count = 1
+    }
   }
 
   # This is currently a mashup of "webcore_rendering" and "webcore_remaining"
   # in GYP. The file list variable is the same and then GYP filters on wether
   # the path starts with "rendering/" or not. We should tweak the .gypis a bit
   # to separate out the rendering files.
   sources = rebase_path(webcore_non_rendering_files, ".", "//")
 
   configs -= core_config_remove
   configs += core_config_add + [
@@ skipping 1017 matching lines @@
   sources = [
     "html/parser/HTMLPreloadScannerFuzzer.cpp",
     "html/parser/TextResourceDecoderForFuzzing.h",
   ]
   seed_corpus = "//third_party/WebKit/LayoutTests/fast/parser"
   deps = [
     ":core",
     "../platform:blink_fuzzer_test_support",
   ]
 }