Inline core HTML and SVG sources in the GN build.

Inline core SVG sources in the GN build.

This adds targets in the corresponding directories where the various SVG files
live. The SVG files are kept in separate targets in the "layout" and "style"
subdirectories so that the current separation of SVG code is maintained.

TBR=dpranke

Committed: https://crrev.com/1dd4387181b432cb60d81ba75e720ea7027824ce
Cr-Commit-Position: refs/heads/master@{#416283}

[brettw, 2016-09-01 22:37:53]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2016-09-01 22:37:58]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 22:38:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 00:16:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 00:16:26]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-09-02 16:40:09]

Description was changed from

==========
Inline core SVG sources in the GN build.

This adds targets in the corresponding directories where the various SVG files
live. The SVG files are kept in separate targets in the "layout" and "style"
subdirectories so that the current separation of SVG code is maintained.
==========

to

==========
Inline core SVG sources in the GN build.

This adds targets in the corresponding directories where the various SVG files
live. The SVG files are kept in separate targets in the "layout" and "style"
subdirectories so that the current separation of SVG code is maintained.

TBR=dpranke
==========

[brettw, 2016-09-02 16:40:41]

You already reviewed some patches in this vein and Dimitri said keeping SVG
separated like I did is probably better. So I'm going to TBR this.

[brettw, 2016-09-02 16:40:45]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-09-02 16:41:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 16:45:21]

Description was changed from

==========
Inline core SVG sources in the GN build.

This adds targets in the corresponding directories where the various SVG files
live. The SVG files are kept in separate targets in the "layout" and "style"
subdirectories so that the current separation of SVG code is maintained.

TBR=dpranke
==========

to

==========
Inline core SVG sources in the GN build.

This adds targets in the corresponding directories where the various SVG files
live. The SVG files are kept in separate targets in the "layout" and "style"
subdirectories so that the current separation of SVG code is maintained.

TBR=dpranke
==========

[commit-bot: I haz the power, 2016-09-02 16:45:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-02 16:46:43]

Description was changed from

==========
Inline core SVG sources in the GN build.

This adds targets in the corresponding directories where the various SVG files
live. The SVG files are kept in separate targets in the "layout" and "style"
subdirectories so that the current separation of SVG code is maintained.

TBR=dpranke
==========

to

==========
Inline core SVG sources in the GN build.

This adds targets in the corresponding directories where the various SVG files
live. The SVG files are kept in separate targets in the "layout" and "style"
subdirectories so that the current separation of SVG code is maintained.

TBR=dpranke

Committed: https://crrev.com/1dd4387181b432cb60d81ba75e720ea7027824ce
Cr-Commit-Position: refs/heads/master@{#416283}
==========

[commit-bot: I haz the power, 2016-09-02 16:46:44]

Patchset 1 (id:??) landed as
https://crrev.com/1dd4387181b432cb60d81ba75e720ea7027824ce
Cr-Commit-Position: refs/heads/master@{#416283}

[Dirk Pranke, 2016-09-02 17:01:38]

lgtm

[Nico, 2016-09-03 03:23:27]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2308953002/ by thakis@chromium.org.

The reason for reverting is: This broke official builds, see
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/b...
:

C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check
  -> returned 1
ERROR at //third_party/WebKit/Source/core/BUILD.gn:52:19: Assignment had no
effect.
    split_count = 5
                  ^
You set the variable "split_count" here and it was unused before it went
out of scope.
See //third_party/WebKit/public/BUILD.gn:53:5: which caused the file to be
included.
    "//third_party/WebKit/Source/core",
    ^---------------------------------

Looks like an easy fix, but I don't have a checkout at hand atm..