dart2js: Pass type information to constructor rather than add later.

dart2js: Pass type information to constructor rather than add later.

This is a redo of https://codereview.chromium.org/1913033002 that fixes some bug with the interactions with type optimizations.

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/9217be050d7bd45eb399ea0b457f8b44eea3892f
Reverted:  https://github.com/dart-lang/sdk/commit/cdd6eeb57dbb2d0715c6b93451ce5861c03afa49
Committed: https://github.com/dart-lang/sdk/commit/c70952c7bc16e8a78acee40cdb3b472a586fe6d8

[sra1, 2016-09-03 01:56:03]

Description was changed from

==========
dart2js: Pass type information to constructor rather than add later.

BUG=
==========

to

==========
dart2js: Pass type information to constructor rather than add later.

This is a redo of https://codereview.chromium.org/1913033002 that fixes some bug
with the interactions with type optimizations.

BUG=
==========

[sra1, 2016-09-03 01:56:04]

sra@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-09-07 17:49:38]

lgtm! just minor nits below

https://codereview.chromium.org/2310573002/diff/100001/pkg/compiler/lib/src/j...
File pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
(right):

https://codereview.chromium.org/2310573002/diff/100001/pkg/compiler/lib/src/j...
pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart:502:
hasRtiField: true, // TODO(sra): Incrementally track this need.
I'm OK keeping this as true - but would it be correct to use
backend.classNeedsRtiField(element) here too?

https://codereview.chromium.org/2310573002/diff/100001/pkg/compiler/lib/src/s...
File pkg/compiler/lib/src/ssa/codegen.dart (right):

https://codereview.chromium.org/2310573002/diff/100001/pkg/compiler/lib/src/s...
pkg/compiler/lib/src/ssa/codegen.dart:1946:
node.instantiatedTypes?.forEach((type) {
nit: while we are at it, use a tear-off instead of a closure?

  node.instantiatedTypes?.forEach(registry.registerInstantiation);

https://codereview.chromium.org/2310573002/diff/100001/pkg/compiler/lib/src/s...
File pkg/compiler/lib/src/ssa/nodes.dart (right):

https://codereview.chromium.org/2310573002/diff/100001/pkg/compiler/lib/src/s...
pkg/compiler/lib/src/ssa/nodes.dart:1506: final bool hasRtiInput; // Is one of
the inputs a reified type?
nit: move this into a dart doc. I'd also highlight that the rti is the last
input, for example:

  /// Whether the last input of this instruction is the reified type.
  final bool hasRtiInput;

https://codereview.chromium.org/2310573002/diff/100001/pkg/compiler/lib/src/s...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/2310573002/diff/100001/pkg/compiler/lib/src/s...
pkg/compiler/lib/src/ssa/optimize.dart:1178:
registry.registerInstantiation(type);
use tearoff here too.

https://codereview.chromium.org/2310573002/diff/100001/pkg/compiler/lib/src/s...
pkg/compiler/lib/src/ssa/optimize.dart:1185: registerInstantiations();
minor nit: how about we remove the `registerInstantiations()` helper, and move
the code into finishSubstituted?

[sra1, 2016-09-07 18:16:07]

https://codereview.chromium.org/2310573002/diff/100001/pkg/compiler/lib/src/j...
File pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
(right):

https://codereview.chromium.org/2310573002/diff/100001/pkg/compiler/lib/src/j...
pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart:502:
hasRtiField: true, // TODO(sra): Incrementally track this need.
On 2016/09/07 17:49:38, Siggi Cherem (dart-lang) wrote:
> I'm OK keeping this as true - but would it be correct to use
> backend.classNeedsRtiField(element) here too?

I'll change it although this method is unused.

https://codereview.chromium.org/2310573002/diff/100001/pkg/compiler/lib/src/s...
File pkg/compiler/lib/src/ssa/codegen.dart (right):

https://codereview.chromium.org/2310573002/diff/100001/pkg/compiler/lib/src/s...
pkg/compiler/lib/src/ssa/codegen.dart:1946:
node.instantiatedTypes?.forEach((type) {
On 2016/09/07 17:49:38, Siggi Cherem (dart-lang) wrote:
> nit: while we are at it, use a tear-off instead of a closure?
> 
>   node.instantiatedTypes?.forEach(registry.registerInstantiation);

Done.

https://codereview.chromium.org/2310573002/diff/100001/pkg/compiler/lib/src/s...
File pkg/compiler/lib/src/ssa/nodes.dart (right):

https://codereview.chromium.org/2310573002/diff/100001/pkg/compiler/lib/src/s...
pkg/compiler/lib/src/ssa/nodes.dart:1506: final bool hasRtiInput; // Is one of
the inputs a reified type?
On 2016/09/07 17:49:38, Siggi Cherem (dart-lang) wrote:
> nit: move this into a dart doc. I'd also highlight that the rti is the last
> input, for example:
> 
>   /// Whether the last input of this instruction is the reified type.
>   final bool hasRtiInput;

Done.

https://codereview.chromium.org/2310573002/diff/100001/pkg/compiler/lib/src/s...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/2310573002/diff/100001/pkg/compiler/lib/src/s...
pkg/compiler/lib/src/ssa/optimize.dart:1178:
registry.registerInstantiation(type);
On 2016/09/07 17:49:38, Siggi Cherem (dart-lang) wrote:
> use tearoff here too.

Done.

https://codereview.chromium.org/2310573002/diff/100001/pkg/compiler/lib/src/s...
pkg/compiler/lib/src/ssa/optimize.dart:1185: registerInstantiations();
On 2016/09/07 17:49:38, Siggi Cherem (dart-lang) wrote:
> minor nit: how about we remove the `registerInstantiations()` helper, and move
> the code into finishSubstituted?

I'll leave it as-is for now. It will need to be refactored for the factory
constructor case.

[sra1, 2016-09-07 19:29:13]

Description was changed from

==========
dart2js: Pass type information to constructor rather than add later.

This is a redo of https://codereview.chromium.org/1913033002 that fixes some bug
with the interactions with type optimizations.

BUG=
==========

to

==========
dart2js: Pass type information to constructor rather than add later.

This is a redo of https://codereview.chromium.org/1913033002 that fixes some bug
with the interactions with type optimizations.

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9217be050d7bd45eb399ea0b457f8b44eea3892f
==========

[sra1, 2016-09-07 19:29:14]

Committed patchset #8 (id:140001) manually as
9217be050d7bd45eb399ea0b457f8b44eea3892f (presubmit successful).

[sra1, 2016-09-07 20:51:47]

Description was changed from

==========
dart2js: Pass type information to constructor rather than add later.

This is a redo of https://codereview.chromium.org/1913033002 that fixes some bug
with the interactions with type optimizations.

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9217be050d7bd45eb399ea0b457f8b44eea3892f
==========

to

==========
dart2js: Pass type information to constructor rather than add later.

This is a redo of https://codereview.chromium.org/1913033002 that fixes some bug
with the interactions with type optimizations.

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9217be050d7bd45eb399ea0b457f8b44eea3892f
Reverted: 
https://github.com/dart-lang/sdk/commit/cdd6eeb57dbb2d0715c6b93451ce5861c03afa49
==========

[sra1, 2016-09-07 22:08:13]

Description was changed from

==========
dart2js: Pass type information to constructor rather than add later.

This is a redo of https://codereview.chromium.org/1913033002 that fixes some bug
with the interactions with type optimizations.

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9217be050d7bd45eb399ea0b457f8b44eea3892f
Reverted: 
https://github.com/dart-lang/sdk/commit/cdd6eeb57dbb2d0715c6b93451ce5861c03afa49
==========

to

==========
dart2js: Pass type information to constructor rather than add later.

This is a redo of https://codereview.chromium.org/1913033002 that fixes some bug
with the interactions with type optimizations.

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9217be050d7bd45eb399ea0b457f8b44eea3892f
Reverted: 
https://github.com/dart-lang/sdk/commit/cdd6eeb57dbb2d0715c6b93451ce5861c03afa49
Committed:
https://github.com/dart-lang/sdk/commit/c70952c7bc16e8a78acee40cdb3b472a586fe6d8
==========

[sra1, 2016-09-07 22:08:14]

Committed patchset #10 (id:180001) manually as
c70952c7bc16e8a78acee40cdb3b472a586fe6d8 (presubmit successful).