dart2js: Pass type information to constructor rather than add later.

pkg/compiler/lib/src/ssa/nodes.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import '../closure.dart';
 import '../common.dart';
 import '../compiler.dart' show Compiler;
 import '../constants/constant_system.dart';
 import '../constants/values.dart';
 import '../dart_types.dart';
@@ skipping 1485 matching lines @@
 
 abstract class HControlFlow extends HInstruction {
   HControlFlow(inputs) : super(inputs, const TypeMask.nonNullEmpty());
   bool isControlFlow() => true;
   bool isJsStatement() => true;
 }
 
 // Allocates and initializes an instance.
 class HCreate extends HInstruction {
   final ClassElement element;
+  final bool hasRtiInput; // Is one of the inputs a reified type?

[Siggi Cherem (dart-lang), 2016/09/07 17:49:38]

nit: move this into a dart doc. I'd also highlight that the rti is the last
input, for example:

  /// Whether the last input of this instruction is the reified type.
  final bool hasRtiInput;

[sra1, 2016/09/07 18:16:06]

Done.

 
   /// If this field is not `null`, this call is from an inlined constructor and
   /// we have to register the instantiated type in the code generator. The
   /// [instructionType] of this node is not enough, because we also need the
   /// type arguments. See also [SsaFromAstMixin.currentInlinedInstantiations].
   List<DartType> instantiatedTypes;
 
   HCreate(this.element, List<HInstruction> inputs, TypeMask type,
-      [this.instantiatedTypes])
+      {this.instantiatedTypes, this.hasRtiInput: false})
       : super(inputs, type);
 
+  bool get isAllocation => true;
+
+  HInstruction get rtiInput {
+    assert(hasRtiInput);
+    return inputs.last;
+  }
+
   accept(HVisitor visitor) => visitor.visitCreate(this);
 
-  bool get isAllocation => true;
-
-  String toString() => 'HCreate($element)';
+  String toString() => 'HCreate($element, ${instantiatedTypes})';
 }
 
 abstract class HInvoke extends HInstruction {
   /**
     * The first argument must be the target: either an [HStatic] node, or
     * the receiver of a method-call. The remaining inputs are the arguments
     * to the invocation.
     */
   HInvoke(List<HInstruction> inputs, type) : super(inputs, type) {
     sideEffects.setAllSideEffects();
@@ skipping 1791 matching lines @@
 
   bool canThrow() => false;
 
   int typeCode() => HInstruction.TYPE_INFO_EXPRESSION_TYPECODE;
   bool typeEquals(HInstruction other) => other is HTypeInfoExpression;
 
   bool dataEquals(HTypeInfoExpression other) {
     return kind == other.kind && dartType == other.dartType;
   }
 
-  String toString() => 'HTypeInfoExpression $kindAsString $dartType';
+  String toString() => 'HTypeInfoExpression($kindAsString, $dartType)';
 
   String get kindAsString {
     switch (kind) {
       case TypeInfoExpressionKind.COMPLETE:
         return 'COMPLETE';
       case TypeInfoExpressionKind.INSTANCE:
         return 'INSTANCE';
     }
   }
 }
@@ skipping 93 matching lines @@
 class HDynamicType extends HRuntimeType {
   HDynamicType(DynamicType dartType, TypeMask instructionType)
       : super(const <HInstruction>[], dartType, instructionType);
 
   accept(HVisitor visitor) => visitor.visitDynamicType(this);
 
   int typeCode() => HInstruction.DYNAMIC_TYPE_TYPECODE;
 
   bool typeEquals(HInstruction other) => other is HDynamicType;
 }