pkg/compiler/lib/src/ssa/codegen.dart - Issue 2310573002: dart2js: Pass type information to constructor rather than add later.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/codegen.dart

Issue 2310573002: dart2js: Pass type information to constructor rather than add later. (Closed)

Patch Set: Filter out type info pseudofield when parsing fieldspec for mirrors Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/ssa/codegen.dart

diff --git a/pkg/compiler/lib/src/ssa/codegen.dart b/pkg/compiler/lib/src/ssa/codegen.dart

index abd0314aa45d4ca41cd3399deef69fe4e94f619a..6faf0b401400a35872cb824e1c11e37e1418890b 100644

--- a/pkg/compiler/lib/src/ssa/codegen.dart

+++ b/pkg/compiler/lib/src/ssa/codegen.dart

@@ -1943,12 +1943,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {

if (node.element.isClosure) {

registry.registerInstantiatedClass(node.element);

}

- if (node.instantiatedTypes == null) {

- return;

- }

- node.instantiatedTypes.forEach((type) {

- registry.registerInstantiation(type);

- });

+ node.instantiatedTypes?.forEach(registry.registerInstantiation);

}

js.Expression newLiteralBool(

« no previous file with comments | « pkg/compiler/lib/src/ssa/builder.dart ('k') | pkg/compiler/lib/src/ssa/nodes.dart » ('j') | no next file with comments »