dart2js: Pass type information to constructor rather than add later.

dart2js: Pass type information to constructor rather than add later.

Committed under another CL

[sra1, 2016-08-19 16:21:03]

sra@google.com changed reviewers:
+ sigmund@google.com

[sra1, 2016-08-19 16:21:04]

I will hold of on committing this until we have testing of --fast-startup.
I have another CL that converts the ad-hoc type representation to new SSA nodes.


Example:

    WhereIterable: {
      "^": "Iterable;_iterable,_f",
      get$iterator: function(_) {
        var t1 = new H.WhereIterator(J.get$iterator$ax(this._iterable),
this._f);
        t1.$builtinTypeInfo = this.$builtinTypeInfo;
        return t1;
      }
    },

--->

    WhereIterable: {
      "^": "Iterable;_iterable,_f,$ti",
      get$iterator: function(_) {
        return new H.WhereIterator(J.get$iterator$ax(this._iterable), this._f,
this.$ti);
      }
    },

[Siggi Cherem (dart-lang), 2016-08-19 16:39:46]

beautiful, lgtm, minor comments below

https://codereview.chromium.org/1913033002/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/constant_emitter.dart (right):

https://codereview.chromium.org/1913033002/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/constant_emitter.dart:257: // Fix. Add an
argument.
did you indent to fix this one with this CL too?

https://codereview.chromium.org/1913033002/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/class_stub_generator.dart (right):

https://codereview.chromium.org/1913033002/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/class_stub_generator.dart:32: typeParameters,
does js_ast remove the extra argument if typeParameters is an empty list? Or do
we need 2 templates function(#) {} and function(#, #) {} ?

https://codereview.chromium.org/1913033002/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart
(right):

https://codereview.chromium.org/1913033002/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart:502:
hasRti: true,      // TODO(sra): fix this.
explain what needs to be fixed?

https://codereview.chromium.org/1913033002/diff/60001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/1913033002/diff/60001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:2377: InterfaceType type =
classElement.thisType;
just to make sure I didn't miss anything: this code here and below just moved
from above, but otherwise is the same, correct?

[sra1, 2017-02-23 23:45:30]

Description was changed from

==========
dart2js: Pass type information to constructor rather than add later.
==========

to

==========
dart2js: Pass type information to constructor rather than add later.

Committed under another CL
==========

[sra1, 2017-02-23 23:46:41]

https://codereview.chromium.org/1913033002/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/class_stub_generator.dart (right):

https://codereview.chromium.org/1913033002/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/class_stub_generator.dart:32: typeParameters,
On 2016/08/19 16:39:46, Siggi Cherem (dart-lang) wrote:
> does js_ast remove the extra argument if typeParameters is an empty list? Or
do
> we need 2 templates function(#) {} and function(#, #) {} ?

# in most repeated contexts will spread a template argument that is an Iterable.
 So "function(#, #) ..." will append two parameter lists.

https://codereview.chromium.org/1913033002/diff/60001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/1913033002/diff/60001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder.dart:2377: InterfaceType type =
classElement.thisType;
On 2016/08/19 16:39:46, Siggi Cherem (dart-lang) wrote:
> just to make sure I didn't miss anything: this code here and below just moved
> from above, but otherwise is the same, correct?

Yes. Since the type arguments are now a parameter, the code needed to be done
before creating the call, instead of after.