Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 2310433002: [tools/perf] Refactor octane benchmark to use GetSystemTotalPhysicalMemory (Closed)

Created:
4 years, 3 months ago by perezju
Modified:
4 years, 3 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Refactor octane benchmark to use GetSystemTotalPhysicalMemory The browser.memory_stats property is being deprecated, so we switch to request platform.GetSystemTotalPhysicalMemory directly. Depends on CL: https://codereview.chromium.org/2308633002 BUG=637217 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/0557c1fcaafb27f8cdfcfd8f0717fc22e5388bcd Cr-Commit-Position: refs/heads/master@{#416522}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M tools/perf/benchmarks/octane.py View 1 chunk +2 lines, -3 lines 3 comments Download

Messages

Total messages: 12 (4 generated)
perezju
4 years, 3 months ago (2016-09-02 16:05:57 UTC) #3
nednguyen
lgtm
4 years, 3 months ago (2016-09-02 16:13:55 UTC) #4
nednguyen
https://codereview.chromium.org/2310433002/diff/1/tools/perf/benchmarks/octane.py File tools/perf/benchmarks/octane.py (right): https://codereview.chromium.org/2310433002/diff/1/tools/perf/benchmarks/octane.py#newcode84 tools/perf/benchmarks/octane.py:84: if total_memory is not None and total_memory < 1 ...
4 years, 3 months ago (2016-09-02 16:15:52 UTC) #5
perezju
https://codereview.chromium.org/2310433002/diff/1/tools/perf/benchmarks/octane.py File tools/perf/benchmarks/octane.py (right): https://codereview.chromium.org/2310433002/diff/1/tools/perf/benchmarks/octane.py#newcode84 tools/perf/benchmarks/octane.py:84: if total_memory is not None and total_memory < 1 ...
4 years, 3 months ago (2016-09-03 10:05:43 UTC) #6
nednguyen
lgtm https://codereview.chromium.org/2310433002/diff/1/tools/perf/benchmarks/octane.py File tools/perf/benchmarks/octane.py (right): https://codereview.chromium.org/2310433002/diff/1/tools/perf/benchmarks/octane.py#newcode84 tools/perf/benchmarks/octane.py:84: if total_memory is not None and total_memory < ...
4 years, 3 months ago (2016-09-03 11:43:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2310433002/1
4 years, 3 months ago (2016-09-05 08:27:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 10:39:07 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 10:40:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0557c1fcaafb27f8cdfcfd8f0717fc22e5388bcd
Cr-Commit-Position: refs/heads/master@{#416522}

Powered by Google App Engine
This is Rietveld 408576698