[tools/perf] Refactor octane benchmark to use GetSystemTotalPhysicalMemory

[tools/perf] Refactor octane benchmark to use GetSystemTotalPhysicalMemory

The browser.memory_stats property is being deprecated, so we switch to
request platform.GetSystemTotalPhysicalMemory directly.

Depends on CL:
https://codereview.chromium.org/2308633002

BUG=637217
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Committed: https://crrev.com/0557c1fcaafb27f8cdfcfd8f0717fc22e5388bcd
Cr-Commit-Position: refs/heads/master@{#416522}

[perezju, 2016-09-02 16:05:19]

Description was changed from

==========
[tools/perf] Refactor octane benchmark to use GetSystemTotalPhysicalMemory

The browser.memory_stats property is being deprecated, so we switch to
request platform.GetSystemTotalPhysicalMemory directly.

Depends on CL:
https://codereview.chromium.org/2308633002

BUG=637217
==========

to

==========
[tools/perf] Refactor octane benchmark to use GetSystemTotalPhysicalMemory

The browser.memory_stats property is being deprecated, so we switch to
request platform.GetSystemTotalPhysicalMemory directly.

Depends on CL:
https://codereview.chromium.org/2308633002

BUG=637217
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

[perezju, 2016-09-02 16:05:56]

perezju@chromium.org changed reviewers:
+ nednguyen@google.com

[nednguyen, 2016-09-02 16:13:55]

lgtm

[nednguyen, 2016-09-02 16:15:52]

https://codereview.chromium.org/2310433002/diff/1/tools/perf/benchmarks/octan...
File tools/perf/benchmarks/octane.py (right):

https://codereview.chromium.org/2310433002/diff/1/tools/perf/benchmarks/octan...
tools/perf/benchmarks/octane.py:84: if total_memory is not None and total_memory
< 1 * _GB:
Actually what do we do with this variable?

[perezju, 2016-09-03 10:05:43]

https://codereview.chromium.org/2310433002/diff/1/tools/perf/benchmarks/octan...
File tools/perf/benchmarks/octane.py (right):

https://codereview.chromium.org/2310433002/diff/1/tools/perf/benchmarks/octan...
tools/perf/benchmarks/octane.py:84: if total_memory is not None and total_memory
< 1 * _GB:
On 2016/09/02 16:15:52, nednguyen wrote:
> Actually what do we do with this variable?

That seems to be it. Just skip the "zlib" test in the octane benchmark if the
platform does not have enough memory.

A bit more context of why the check was added:
https://codereview.chromium.org/450873002

I can see some alternatives:
- Remove the check entirely, and see whether this breaks or not on some devices
- Check for IsSvelte instead?

[nednguyen, 2016-09-03 11:43:05]

lgtm

https://codereview.chromium.org/2310433002/diff/1/tools/perf/benchmarks/octan...
File tools/perf/benchmarks/octane.py (right):

https://codereview.chromium.org/2310433002/diff/1/tools/perf/benchmarks/octan...
tools/perf/benchmarks/octane.py:84: if total_memory is not None and total_memory
< 1 * _GB:
On 2016/09/03 10:05:43, perezju wrote:
> On 2016/09/02 16:15:52, nednguyen wrote:
> > Actually what do we do with this variable?
> 
> That seems to be it. Just skip the "zlib" test in the octane benchmark if the
> platform does not have enough memory.
> 
> A bit more context of why the check was added:
> https://codereview.chromium.org/450873002
> 
> I can see some alternatives:
> - Remove the check entirely, and see whether this breaks or not on some
devices
> - Check for IsSvelte instead?

I see. Let's just keep this as-is to unblock your cleanup.

[perezju, 2016-09-05 08:27:41]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2016-09-05 08:27:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 10:39:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-05 10:40:51]

Description was changed from

==========
[tools/perf] Refactor octane benchmark to use GetSystemTotalPhysicalMemory

The browser.memory_stats property is being deprecated, so we switch to
request platform.GetSystemTotalPhysicalMemory directly.

Depends on CL:
https://codereview.chromium.org/2308633002

BUG=637217
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

to

==========
[tools/perf] Refactor octane benchmark to use GetSystemTotalPhysicalMemory

The browser.memory_stats property is being deprecated, so we switch to
request platform.GetSystemTotalPhysicalMemory directly.

Depends on CL:
https://codereview.chromium.org/2308633002

BUG=637217
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Committed: https://crrev.com/0557c1fcaafb27f8cdfcfd8f0717fc22e5388bcd
Cr-Commit-Position: refs/heads/master@{#416522}
==========

[commit-bot: I haz the power, 2016-09-05 10:40:52]

Patchset 1 (id:??) landed as
https://crrev.com/0557c1fcaafb27f8cdfcfd8f0717fc22e5388bcd
Cr-Commit-Position: refs/heads/master@{#416522}