Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: tools/perf/benchmarks/octane.py

Issue 2310433002: [tools/perf] Refactor octane benchmark to use GetSystemTotalPhysicalMemory (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/octane.py
diff --git a/tools/perf/benchmarks/octane.py b/tools/perf/benchmarks/octane.py
index 4c7aa5ee947178ce06061895f18e007dfdd42143..02fb9bf46eff08a0642e55e8c588ddd53aa7226e 100644
--- a/tools/perf/benchmarks/octane.py
+++ b/tools/perf/benchmarks/octane.py
@@ -80,9 +80,8 @@ class _OctaneMeasurement(legacy_page_test.LegacyPageTest):
self._power_metric = power.PowerMetric(platform)
def WillNavigateToPage(self, page, tab):
- memory_stats = tab.browser.memory_stats
- if ('SystemTotalPhysicalMemory' in memory_stats and
- memory_stats['SystemTotalPhysicalMemory'] < 1 * _GB):
+ total_memory = tab.browser.platform.GetSystemTotalPhysicalMemory()
+ if total_memory is not None and total_memory < 1 * _GB:
nednguyen 2016/09/02 16:15:52 Actually what do we do with this variable?
perezju 2016/09/03 10:05:43 That seems to be it. Just skip the "zlib" test in
nednguyen 2016/09/03 11:43:05 I see. Let's just keep this as-is to unblock your
skipBenchmarks = '"zlib"'
else:
skipBenchmarks = ''
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698