Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 450873002: [Telemetry] Fix Octane on non-rooted devices. (Closed)

Created:
6 years, 4 months ago by tonyg
Modified:
6 years, 4 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Fix Octane on non-rooted devices. This condition was added to prevent the zlib benchmark from OOMing on the Galaxy Nexus device. Now, it's no longer on the waterfall, so I'm just removing the check. This has the desired side-effect that we'll try to run this benchmark on any device, even if we can't determine the physical memory. BUG=391079 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288486

Patch Set 1 #

Patch Set 2 : Maintain check when possible #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/perf/benchmarks/octane.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tonyg
6 years, 4 months ago (2014-08-08 03:44:04 UTC) #1
tonyg
Hey Ross, here's a new approach that maintains the check when possible. WDYT?
6 years, 4 months ago (2014-08-08 17:37:17 UTC) #2
rmcilroy
On 2014/08/08 17:37:17, tonyg wrote: > Hey Ross, here's a new approach that maintains the ...
6 years, 4 months ago (2014-08-08 22:20:00 UTC) #3
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-08-08 23:08:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/450873002/20001
6 years, 4 months ago (2014-08-08 23:09:32 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 01:39:47 UTC) #6
Message was sent while issue was closed.
Change committed as 288486

Powered by Google App Engine
This is Rietveld 408576698