Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2308633002:
[Telemetry] Expose platform.GetSystemTotalPhysicalMemory (Closed)
Description[Telemetry] Expose platform.GetSystemTotalPhysicalMemory
Required by some benchmarks to black-list test cases.
BUG=chromium:637217
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/1f08948ad3a98ee2c87de5d1db75f503e2089f2b
Patch Set 1 #
Total comments: 4
Patch Set 2 : leave default impl to raise not implemented #
Messages
Total messages: 15 (7 generated)
perezju@chromium.org changed reviewers: + nednguyen@google.com
https://codereview.chromium.org/2308633002/diff/1/telemetry/telemetry/interna... File telemetry/telemetry/internal/platform/platform_backend.py (right): https://codereview.chromium.org/2308633002/diff/1/telemetry/telemetry/interna... telemetry/telemetry/internal/platform/platform_backend.py:145: return None This is only non implemented in Android. Can we keep it NotImplementedError() & add an implementation for Android?
https://codereview.chromium.org/2308633002/diff/1/telemetry/telemetry/interna... File telemetry/telemetry/internal/platform/platform_backend.py (right): https://codereview.chromium.org/2308633002/diff/1/telemetry/telemetry/interna... telemetry/telemetry/internal/platform/platform_backend.py:145: return None On 2016/09/02 16:17:04, nednguyen wrote: > This is only non implemented in Android. Can we keep it NotImplementedError() & > add an implementation for Android? Android *does* inherit the implementation from linux_based_platform.
https://codereview.chromium.org/2308633002/diff/1/telemetry/telemetry/interna... File telemetry/telemetry/internal/platform/platform_backend.py (right): https://codereview.chromium.org/2308633002/diff/1/telemetry/telemetry/interna... telemetry/telemetry/internal/platform/platform_backend.py:145: return None On 2016/09/03 10:07:13, perezju wrote: > On 2016/09/02 16:17:04, nednguyen wrote: > > This is only non implemented in Android. Can we keep it NotImplementedError() > & > > add an implementation for Android? > > Android *does* inherit the implementation from linux_based_platform. Then I believe there is no need to change this.
https://codereview.chromium.org/2308633002/diff/1/telemetry/telemetry/interna... File telemetry/telemetry/internal/platform/platform_backend.py (right): https://codereview.chromium.org/2308633002/diff/1/telemetry/telemetry/interna... telemetry/telemetry/internal/platform/platform_backend.py:145: return None On 2016/09/03 11:37:04, nednguyen wrote: > On 2016/09/03 10:07:13, perezju wrote: > > On 2016/09/02 16:17:04, nednguyen wrote: > > > This is only non implemented in Android. Can we keep it > NotImplementedError() > > & > > > add an implementation for Android? > > > > Android *does* inherit the implementation from linux_based_platform. > > Then I believe there is no need to change this. Done.
The CQ bit was checked by perezju@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by perezju@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Telemetry] Expose platform.GetSystemTotalPhysicalMemory Required by some benchmarks to black-list test cases. BUG=chromium:637217 ========== to ========== [Telemetry] Expose platform.GetSystemTotalPhysicalMemory Required by some benchmarks to black-list test cases. BUG=chromium:637217 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
