[heap] Introduce enum of garbage collection reasons.

[heap] Introduce enum of garbage collection reasons.

Now callers of Heap::CollectGarbage* functions need to
specify the reason as an enum value instead of a string.

Subsequent CL will add stats counter for GC reason.

BUG=

Committed: https://crrev.com/1b26611ce953e2867926af5c5c3d3f2a006384d6
Cr-Commit-Position: refs/heads/master@{#39239}

[ulan, 2016-09-06 17:17:51]

The CQ bit was checked by ulan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 17:18:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 17:19:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 17:19:32]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/12243)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[ulan, 2016-09-06 17:21:46]

Description was changed from

==========
[heap] Introduce enum of garbage collection reasons.

BUG=
==========

to

==========
[heap] Introduce enum of garbage collection reasons.

Now callers of Heap::CollectGarbage* functions need to
specify the reason as enum value instead of a string.

This will allow us to add GC reason stats.

BUG=
==========

[ulan, 2016-09-06 17:31:57]

The CQ bit was checked by ulan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 17:32:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 17:38:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 17:38:18]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/13770)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/13799)

[ulan, 2016-09-06 17:43:49]

The CQ bit was checked by ulan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 17:43:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ulan, 2016-09-06 17:44:54]

Description was changed from

==========
[heap] Introduce enum of garbage collection reasons.

Now callers of Heap::CollectGarbage* functions need to
specify the reason as enum value instead of a string.

This will allow us to add GC reason stats.

BUG=
==========

to

==========
[heap] Introduce enum of garbage collection reasons.

Now callers of Heap::CollectGarbage* functions need to
specify the reason as an enum value instead of a string.

Subsequent CL will add stats counter for GC reason.


BUG=
==========

[ulan, 2016-09-06 17:48:47]

ulan@chromium.org changed reviewers:
+ mlippautz@chromium.org

[ulan, 2016-09-06 17:48:48]

PTAL

[commit-bot: I haz the power, 2016-09-06 18:12:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 18:12:17]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2016-09-07 07:28:31]

lgtm (mostly rubberstamp on test/)

https://codereview.chromium.org/2310143002/diff/80001/src/heap/gc-tracer.h
File src/heap/gc-tracer.h (right):

https://codereview.chromium.org/2310143002/diff/80001/src/heap/gc-tracer.h#ne...
src/heap/gc-tracer.h:398: static const char* GarbageCollectionReasonToString(
nit: I would move the function somewhere into heap.{h,cc}. I can see this
printing useful outside of GCTracer and we actually already use it in
incremental-marking.

[ulan, 2016-09-07 09:25:13]

https://codereview.chromium.org/2310143002/diff/80001/src/heap/gc-tracer.h
File src/heap/gc-tracer.h (right):

https://codereview.chromium.org/2310143002/diff/80001/src/heap/gc-tracer.h#ne...
src/heap/gc-tracer.h:398: static const char* GarbageCollectionReasonToString(
On 2016/09/07 07:28:31, Michael Lippautz wrote:
> nit: I would move the function somewhere into heap.{h,cc}. I can see this
> printing useful outside of GCTracer and we actually already use it in
> incremental-marking.

Done.

[ulan, 2016-09-07 09:25:17]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-09-07 09:25:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/2310143002/#ps100001
(title: "move GarbageCollectionReasonToString to heap")

[commit-bot: I haz the power, 2016-09-07 09:25:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 09:26:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 09:26:58]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/12287)

[ulan, 2016-09-07 09:33:45]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-09-07 09:33:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org
Link to the patchset: https://codereview.chromium.org/2310143002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-07 09:33:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 10:03:01]

Description was changed from

==========
[heap] Introduce enum of garbage collection reasons.

Now callers of Heap::CollectGarbage* functions need to
specify the reason as an enum value instead of a string.

Subsequent CL will add stats counter for GC reason.


BUG=
==========

to

==========
[heap] Introduce enum of garbage collection reasons.

Now callers of Heap::CollectGarbage* functions need to
specify the reason as an enum value instead of a string.

Subsequent CL will add stats counter for GC reason.


BUG=
==========

[commit-bot: I haz the power, 2016-09-07 10:03:03]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-07 10:03:18]

Description was changed from

==========
[heap] Introduce enum of garbage collection reasons.

Now callers of Heap::CollectGarbage* functions need to
specify the reason as an enum value instead of a string.

Subsequent CL will add stats counter for GC reason.


BUG=
==========

to

==========
[heap] Introduce enum of garbage collection reasons.

Now callers of Heap::CollectGarbage* functions need to
specify the reason as an enum value instead of a string.

Subsequent CL will add stats counter for GC reason.

BUG=

Committed: https://crrev.com/1b26611ce953e2867926af5c5c3d3f2a006384d6
Cr-Commit-Position: refs/heads/master@{#39239}
==========

[commit-bot: I haz the power, 2016-09-07 10:03:19]

Patchset 7 (id:??) landed as
https://crrev.com/1b26611ce953e2867926af5c5c3d3f2a006384d6
Cr-Commit-Position: refs/heads/master@{#39239}