Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: src/heap/memory-reducer.cc

Issue 2310143002: [heap] Introduce enum of garbage collection reasons. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/incremental-marking-job.cc ('k') | src/heap/scavenge-job.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/heap/memory-reducer.h" 5 #include "src/heap/memory-reducer.h"
6 6
7 #include "src/flags.h" 7 #include "src/flags.h"
8 #include "src/heap/gc-tracer.h" 8 #include "src/heap/gc-tracer.h"
9 #include "src/heap/heap-inl.h" 9 #include "src/heap/heap-inl.h"
10 #include "src/utils.h" 10 #include "src/utils.h"
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 DCHECK_EQ(kTimer, event.type); 66 DCHECK_EQ(kTimer, event.type);
67 DCHECK_EQ(kWait, state_.action); 67 DCHECK_EQ(kWait, state_.action);
68 state_ = Step(state_, event); 68 state_ = Step(state_, event);
69 if (state_.action == kRun) { 69 if (state_.action == kRun) {
70 DCHECK(heap()->incremental_marking()->IsStopped()); 70 DCHECK(heap()->incremental_marking()->IsStopped());
71 DCHECK(FLAG_incremental_marking); 71 DCHECK(FLAG_incremental_marking);
72 if (FLAG_trace_gc_verbose) { 72 if (FLAG_trace_gc_verbose) {
73 PrintIsolate(heap()->isolate(), "Memory reducer: started GC #%d\n", 73 PrintIsolate(heap()->isolate(), "Memory reducer: started GC #%d\n",
74 state_.started_gcs); 74 state_.started_gcs);
75 } 75 }
76 heap()->StartIdleIncrementalMarking(); 76 heap()->StartIdleIncrementalMarking(
77 GarbageCollectionReason::kMemoryReducer);
77 } else if (state_.action == kWait) { 78 } else if (state_.action == kWait) {
78 if (!heap()->incremental_marking()->IsStopped() && 79 if (!heap()->incremental_marking()->IsStopped() &&
79 heap()->ShouldOptimizeForMemoryUsage()) { 80 heap()->ShouldOptimizeForMemoryUsage()) {
80 // Make progress with pending incremental marking if memory usage has 81 // Make progress with pending incremental marking if memory usage has
81 // higher priority than latency. This is important for background tabs 82 // higher priority than latency. This is important for background tabs
82 // that do not send idle notifications. 83 // that do not send idle notifications.
83 const int kIncrementalMarkingDelayMs = 500; 84 const int kIncrementalMarkingDelayMs = 500;
84 double deadline = heap()->MonotonicallyIncreasingTimeInMs() + 85 double deadline = heap()->MonotonicallyIncreasingTimeInMs() +
85 kIncrementalMarkingDelayMs; 86 kIncrementalMarkingDelayMs;
86 heap()->incremental_marking()->AdvanceIncrementalMarking( 87 heap()->incremental_marking()->AdvanceIncrementalMarking(
87 deadline, IncrementalMarking::NO_GC_VIA_STACK_GUARD, 88 deadline, IncrementalMarking::NO_GC_VIA_STACK_GUARD,
88 IncrementalMarking::FORCE_COMPLETION); 89 IncrementalMarking::FORCE_COMPLETION);
89 heap()->FinalizeIncrementalMarkingIfComplete( 90 heap()->FinalizeIncrementalMarkingIfComplete(
90 "Memory reducer: finalize incremental marking"); 91 GarbageCollectionReason::kFinalizeMarkingViaTask);
91 } 92 }
92 // Re-schedule the timer. 93 // Re-schedule the timer.
93 ScheduleTimer(event.time_ms, state_.next_gc_start_ms - event.time_ms); 94 ScheduleTimer(event.time_ms, state_.next_gc_start_ms - event.time_ms);
94 if (FLAG_trace_gc_verbose) { 95 if (FLAG_trace_gc_verbose) {
95 PrintIsolate(heap()->isolate(), "Memory reducer: waiting for %.f ms\n", 96 PrintIsolate(heap()->isolate(), "Memory reducer: waiting for %.f ms\n",
96 state_.next_gc_start_ms - event.time_ms); 97 state_.next_gc_start_ms - event.time_ms);
97 } 98 }
98 } 99 }
99 } 100 }
100 101
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 auto timer_task = new MemoryReducer::TimerTask(this); 202 auto timer_task = new MemoryReducer::TimerTask(this);
202 V8::GetCurrentPlatform()->CallDelayedOnForegroundThread( 203 V8::GetCurrentPlatform()->CallDelayedOnForegroundThread(
203 isolate, timer_task, (delay_ms + kSlackMs) / 1000.0); 204 isolate, timer_task, (delay_ms + kSlackMs) / 1000.0);
204 } 205 }
205 206
206 207
207 void MemoryReducer::TearDown() { state_ = State(kDone, 0, 0, 0.0); } 208 void MemoryReducer::TearDown() { state_ = State(kDone, 0, 0, 0.0); }
208 209
209 } // namespace internal 210 } // namespace internal
210 } // namespace v8 211 } // namespace v8
OLDNEW
« no previous file with comments | « src/heap/incremental-marking-job.cc ('k') | src/heap/scavenge-job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698