Replaced PassRefPtr copies with moves in Source/web and Source/wtf.

Replaced PassRefPtr copies with moves in Source/web and Source/wtf.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

BUG=640449
Committed: https://crrev.com/5e4e8c6fb5346db13860874efb6d988af79eb408
Cr-Commit-Position: refs/heads/master@{#418493}

[Bugs Nash, 2016-09-05 04:25:22]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 04:25:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2016-09-05 04:25:51]

bugsnash@chromium.org changed reviewers:
+ yutak@chromium.org

[commit-bot: I haz the power, 2016-09-05 04:31:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 04:31:37]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Bugs Nash, 2016-09-05 04:40:12]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 04:40:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 05:12:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 05:12:14]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Yuta Kitamura, 2016-09-05 06:46:09]

Looks good except for HashMap.h. I suppose the try failures
are caused by it.

https://codereview.chromium.org/2308353002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/HashMap.h (right):

https://codereview.chromium.org/2308353002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/HashMap.h:255:
ValueTraits::ValueTraits::store(std::move(std::forward<V>(mapped)),
location.value);
Nesting std::move and std::forward does not make sense; forward()
is a generalized version of move(), thus you probably don't want
to touch here.

I guess the real error is in somewhere else, likely in a call
site of HashMap::add() or the like.

https://codereview.chromium.org/2308353002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/HashMap.h:374:
MappedTraits::store(std::move(std::forward<IncomingMappedType>(mapped)),
result.storedValue->value);
Ditto.

[Bugs Nash, 2016-09-14 01:29:19]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 01:29:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 05:02:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 05:02:30]

Dry run: This issue passed the CQ dry run.

[Bugs Nash, 2016-09-14 05:22:36]

bugsnash@chromium.org changed reviewers:
+ haraken@chromium.org

[Bugs Nash, 2016-09-14 05:23:29]

+haraken for Source/web

https://codereview.chromium.org/2308353002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/HashMap.h (right):

https://codereview.chromium.org/2308353002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/HashMap.h:255:
ValueTraits::ValueTraits::store(std::move(std::forward<V>(mapped)),
location.value);
On 2016/09/05 at 06:46:09, Yuta Kitamura wrote:
> Nesting std::move and std::forward does not make sense; forward()
> is a generalized version of move(), thus you probably don't want
> to touch here.
> 
> I guess the real error is in somewhere else, likely in a call
> site of HashMap::add() or the like.

Done

https://codereview.chromium.org/2308353002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/HashMap.h:374:
MappedTraits::store(std::move(std::forward<IncomingMappedType>(mapped)),
result.storedValue->value);
On 2016/09/05 at 06:46:09, Yuta Kitamura wrote:
> Ditto.

Done

[haraken, 2016-09-14 05:27:29]

LGTM

[Yuta Kitamura, 2016-09-14 05:35:39]

lgtm

[Bugs Nash, 2016-09-14 05:39:16]

The CQ bit was checked by bugsnash@chromium.org

[Bugs Nash, 2016-09-14 05:39:19]

The CQ bit was checked by bugsnash@chromium.org

[commit-bot: I haz the power, 2016-09-14 05:39:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 05:44:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-14 05:47:08]

Description was changed from

==========
Replaced PassRefPtr copies with moves in Source/web and Source/wtf.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

BUG=640449
==========

to

==========
Replaced PassRefPtr copies with moves in Source/web and Source/wtf.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

BUG=640449

Committed: https://crrev.com/5e4e8c6fb5346db13860874efb6d988af79eb408
Cr-Commit-Position: refs/heads/master@{#418493}
==========

[commit-bot: I haz the power, 2016-09-14 05:47:09]

Patchset 3 (id:??) landed as
https://crrev.com/5e4e8c6fb5346db13860874efb6d988af79eb408
Cr-Commit-Position: refs/heads/master@{#418493}